-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPM Package Registry search API endpoint #20280
Conversation
There's a couple of things left that I'm not sure how to implement:
"time": {
"modified": "2022-03-01T22:58:17.890Z"
}, This isn't included in the NPM specs that I linked, but Unity seems to read it to display publish time.
|
Could you give me write access for your Gitea fork? I added some changes for this PR. |
I do have |
Could you please merge with the current main branch? |
Thanks, added PR jackv24#1 |
Implement npm search api
@KN4CK3R , I think it looks good ~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it's fine. I don't know if the registry should support these non-standard features for Unity. The search endpoint at it's own does work.
* upstream/main: [skip ci] Updated translations via Crowdin Typo in config-cheat-sheet (go-gitea#21261) Use native inputs in whitespace dropdown (go-gitea#20980) [skip ci] Updated licenses and gitignores Use en-US as fallback when using other default language (go-gitea#21200) Make NuGet service index publicly accessible (go-gitea#21242) Save files in local storage as umask (go-gitea#21198) NPM Package Registry search API endpoint (go-gitea#20280) [skip ci] Updated translations via Crowdin Added search input field to issue filter (go-gitea#20623)
WIP for #20098, implemented to match what's described here in the NPM registry API.
Currently have only implemented the bare minimum to work with the Unity Package Manager.
I've never written Go code before, and this is my first time contributing so please let me know if anything can be improved!