Initialize cron last #20373
Merged
Initialize cron last #20373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cron will try to run certain things at startup but these depend on multiple things being set-up. Therefore we should initialize cron last. Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
approved these changes
Jul 14, 2022
GiteaBot
added
the
lgtm/need 1
techknowlogick
approved these changes
Jul 14, 2022
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #20373 +/- ##
=======================================
Coverage ? 46.81%
=======================================
Files ? 976
Lines ? 135186
Branches ? 0
=======================================
Hits ? 63286
Misses ? 64136
Partials ? 7764
Continue to review full report at Codecov.
|
zeripath
deleted the
fix-20367-only-initialize-cron-after-everything-ready
branch
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jul 15, 2022
Backport go-gitea#20373 Cron will try to run certain things at startup but these depend on multiple things being set-up. Therefore we should initialize cron last. Signed-off-by: Andrew Thornton <art27@cantab.net>
techknowlogick
pushed a commit
that referenced
this pull request
Jul 15, 2022
dineshsalunke
pushed a commit
to dineshsalunke/gitea
that referenced
this pull request
Jul 15, 2022
Cron will try to run certain things at startup but these depend on multiple things being set-up. Therefore we should initialize cron last. Signed-off-by: Andrew Thornton <art27@cantab.net>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 18, 2022
* giteaofficial/main: [skip ci] Updated licenses and gitignores Comment on PrivateUsers option for gitea.service (go-gitea#20383) [skip ci] Updated translations via Crowdin Remove confusing TrimPrefix(... git.BranchPrefix) (go-gitea#20369) Set target on create release with existing tag (go-gitea#20381) Initialize cron last (go-gitea#20373) Allow access to the Public Organization Member lists with minimal permissions (go-gitea#20330)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
Cron will try to run certain things at startup but these depend on multiple things being set-up. Therefore we should initialize cron last. Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cron will try to run certain things at startup but these depend on multiple things
being set-up. Therefore we should initialize cron last.
Fix #20367
Signed-off-by: Andrew Thornton art27@cantab.net