-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: tests use ed25519 ssh key #20416
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
type/enhancement
An improvement of existing functionality
type/testing
labels
Jul 19, 2022
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jul 19, 2022
if I add them manually via web interface they work ?!? |
Could you try to use the marshaling code from #18835 ? I had to do a few tweaks to get Ed25519 keypairs nicely working with all software. |
Do we still need this test? If it is for the ssh-rsa key problem, Golang has fixed it. |
wxiaoguang
added
the
issue/needs-feedback
For bugs, we need more details. For features, the feature must be described in more detail
label
Apr 25, 2023
Second ping |
I guess this could be closed. Feel free to reopen ~~~~ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
issue/needs-feedback
For bugs, we need more details. For features, the feature must be described in more detail
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
type/enhancement
An improvement of existing functionality
type/testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #17786
test: https://go.dev/play/p/Mu0H8t4_p_J
alternative (ecdsa): https://go.dev/play/p/98zK-E7CAfy
old rsa: https://go.dev/play/p/IpCJ7AnCyTR