Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: tests use ed25519 ssh key #20416

Closed
wants to merge 6 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 19, 2022

@6543 6543 added type/enhancement An improvement of existing functionality type/testing labels Jul 19, 2022
@6543 6543 added this to the 1.18.0 milestone Jul 19, 2022
@6543 6543 changed the title Tests use ed25519 ssh key WIP: tests use ed25519 ssh key Jul 19, 2022
@6543
Copy link
Member Author

6543 commented Jul 19, 2022

[E] {"message":"Invalid key content: failed to parse DER encoded public key as either PKIX or PEM RSA Key: asn1: structure error: tags don't match (16 vs {class:1 tag:15 length:112 isCompound:true}) {optional:false explicit:false application:false private:false defaultValue:\u003cnil\u003e tag:\u003cnil\u003e stringType:0 timeType:0 set:false omitEmpty:false} publicKeyInfo @2 asn1: structure error: tags don't match (16 vs {class:1 tag:15 length:112 isCompound:true}) {optional:false explicit:false application:false private:false defaultValue:\u003cnil\u003e tag:\u003cnil\u003e stringType:0 timeType:0 set:false omitEmpty:false} PublicKey @2","url":"http://localhost:3003/api/swagger"}
        --- FAIL: TestGit/SSH/CreateUserKey (0.01s)
            api_helper_for_declarative_test.go:179: 
                	Error Trace:	integration_test.go:508
                	            				integration_test.go:337
                	            				api_helper_for_declarative_test.go:179
                	Error:      	Not equal: 
                	            	expected: 201
                	            	actual  : 422
                	Test:       	TestGit/SSH/CreateUserKey
                	Messages:   	Request: POST /api/v1/user/keys?token=2b1a1cb4cd1ed88d02e6acaa1ea662462854b12d

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 19, 2022
@6543
Copy link
Member Author

6543 commented Jul 19, 2022

if I add them manually via web interface they work ?!?

@Gusted
Copy link
Contributor

Gusted commented Jul 21, 2022

Could you try to use the marshaling code from #18835 ? I had to do a few tweaks to get Ed25519 keypairs nicely working with all software.

@lunny lunny modified the milestones: 1.18.0, 1.19.0 Oct 17, 2022
@lunny lunny modified the milestones: 1.19.0, 1.20.0 Jan 31, 2023
@wxiaoguang
Copy link
Contributor

Do we still need this test? If it is for the ssh-rsa key problem, Golang has fixed it.

@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Apr 25, 2023
@wxiaoguang
Copy link
Contributor

Second ping

@wxiaoguang
Copy link
Contributor

I guess this could be closed.

Feel free to reopen ~~~~

@wxiaoguang wxiaoguang closed this May 5, 2023
@GiteaBot GiteaBot removed this from the 1.20.0 milestone May 5, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/enhancement An improvement of existing functionality type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants