Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide internal package versions (#20492) #20500

Closed
wants to merge 1 commit into from
Closed

Hide internal package versions (#20492) #20500

wants to merge 1 commit into from

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Jul 27, 2022

Backport #20492

@KN4CK3R
Hide internal package versions (go-gitea#20492)
edfc6c3 
* Hide internal versions from most searches.

* Added test.
@KN4CK3R KN4CK3R added this to the 1.17.0 milestone Jul 27, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 27, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 27, 2022
@lafriks
Copy link
Member

lafriks commented Jul 27, 2022

Lint fails

@KN4CK3R
Copy link
Member Author

KN4CK3R commented Jul 27, 2022

The lint reveals why this problem occurred in the first place. #18064 made the IsInternal optional which resulted in the wrong API result. So this backport is not needed because the error is only in 1.18.

@KN4CK3R KN4CK3R closed this Jul 27, 2022
@KN4CK3R KN4CK3R deleted the backport-fix-20491 branch August 5, 2022 09:41
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noerw noerw noerw approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/packages type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@KN4CK3R @lafriks @noerw @GiteaBot