Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default item listing size ISSUE_PAGING_NUM to 20 #20547

Merged
merged 14 commits into from
Aug 6, 2022
Merged

Increase default item listing size ISSUE_PAGING_NUM to 20 #20547

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4a47f4a
increase default page sizes to 20
noerw Jul 29, 2022
e351b13
adjust docs to reflect that the setting is used all over the place
noerw Jul 29, 2022
683b4db
Merge branch 'main' into incr-issue-paging-num
lunny Jul 30, 2022
f1ec841
adjust tests
noerw Jul 30, 2022
ba8b1be
fix tests 2
noerw Jul 31, 2022
0930750
fix remaining test cases
noerw Jul 31, 2022
14a84ca
speaking of duplicate tests...
noerw Jul 31, 2022
1c13962
Merge branch 'main' into incr-issue-paging-num
noerw Jul 31, 2022
c835b7a
Merge branch 'main' into incr-issue-paging-num
wxiaoguang Aug 2, 2022
d78677d
Merge branch 'main' into incr-issue-paging-num
wxiaoguang Aug 2, 2022
6850f58
Merge branch 'main' into incr-issue-paging-num
wxiaoguang Aug 2, 2022
8e8a72d
Merge branch 'main' into incr-issue-paging-num
wxiaoguang Aug 2, 2022
07ac45d
Merge branch 'main' into incr-issue-paging-num
wxiaoguang Aug 3, 2022
7e992e7
Merge branch 'main' into incr-issue-paging-num
wxiaoguang Aug 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion custom/conf/app.example.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,7 @@ ROUTER = console
;EXPLORE_PAGING_NUM = 20
;;
;; Number of issues that are displayed on one page
;ISSUE_PAGING_NUM = 10
;ISSUE_PAGING_NUM = 20
;;
;; Number of maximum commits displayed in one activity feed
;FEED_MAX_COMMIT_NUM = 5
Expand Down
2 changes: 1 addition & 1 deletion docs/content/doc/advanced/config-cheat-sheet.en-us.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ The following configuration set `Content-Type: application/vnd.android.package-a
## UI (`ui`)

- `EXPLORE_PAGING_NUM`: **20**: Number of repositories that are shown in one explore page.
- `ISSUE_PAGING_NUM`: **10**: Number of issues that are shown in one page (for all pages that list issues).
- `ISSUE_PAGING_NUM`: **20**: Number of issues that are shown in one page (for all pages that list issues, milestones, projects).
- `MEMBERS_PAGING_NUM`: **20**: Number of members that are shown in organization members.
- `FEED_MAX_COMMIT_NUM`: **5**: Number of maximum commits shown in one activity feed.
- `FEED_PAGING_NUM`: **20**: Number of items that are displayed in home feed.
Expand Down
4 changes: 2 additions & 2 deletions modules/setting/setting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,8 @@ var (
}{
ExplorePagingNum: 20,
SitemapPagingNum: 20,
IssuePagingNum: 10,
RepoSearchPagingNum: 10,
IssuePagingNum: 20,
RepoSearchPagingNum: 20,
noerw marked this conversation as resolved.
Show resolved Hide resolved
MembersPagingNum: 20,
FeedMaxCommitNum: 5,
FeedPagingNum: 20,
Expand Down