-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disable part user settings #20549
Draft
lunny
wants to merge
12
commits into
go-gitea:main
Choose a base branch
from
lunny:lunny/disable_user_setting_via_modules
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d647042
Allow disalbe part user settings
lunny 72959dc
Use a suitable word for deletion of user data
lunny e160a06
Fix missed word
lunny a84950a
Fix typo
lunny a10c911
Use constants
lunny 6810325
Fix bug
lunny e464f8a
fix lint
lunny 48be421
merge main branch
lunny 32135d9
merge main branch
lunny be45ca3
Add more limitation for user organization setting
lunny 0d83370
Merge branch 'main' into lunny/disable_user_setting_via_modules
lunny 148b74d
merge main branch
lunny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -1386,6 +1386,16 @@ steps: | |||||||||||||||||||||||||
|
||||||||||||||||||||||||||
although Github don't support this form. | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
## User (`user`) | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
- `USER_SETTING_DISABLED_MODULES`:**** Disabled modules from user settings, could be a copmosite of `password`, `deletion`, `security`, `applications`, `gpg keys`, `organizations` with a comma. | ||||||||||||||||||||||||||
- `password`: User cannot change his password from the website. | ||||||||||||||||||||||||||
- `deletion`: User cannot remove himself from the website. | ||||||||||||||||||||||||||
- `security`: User cannot update his security settings from the website. | ||||||||||||||||||||||||||
- `applications`: User cannot create application himself. | ||||||||||||||||||||||||||
- `gpg_keys`: User cannot manage gpg keys himself. | ||||||||||||||||||||||||||
- `organizations`: User cannot manage his organizations himself. | ||||||||||||||||||||||||||
Comment on lines
+1392
to
+1397
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
## Other (`other`) | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
- `SHOW_FOOTER_BRANDING`: **false**: Show Gitea branding in the footer. | ||||||||||||||||||||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// Copyright 2022 The Gitea Authors. All rights reserved. | ||
// SPDX-License-Identifier: MIT | ||
|
||
package setting | ||
|
||
import ( | ||
"strings" | ||
|
||
"code.gitea.io/gitea/modules/container" | ||
) | ||
|
||
// userSetting represents user settings | ||
type userSetting struct { | ||
content container.Set[string] | ||
} | ||
|
||
func (s *userSetting) Enabled(module string) bool { | ||
return !s.content.Contains(strings.ToLower(module)) | ||
} | ||
|
||
var User userSetting | ||
|
||
func loadUserFrom(rootCfg ConfigProvider) { | ||
sec := rootCfg.Section("user") | ||
values := sec.Key("SETTING_DISABLED_MODULES").Strings(",") | ||
User.content = container.SetOf(values...) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind the spelling of
copmosite