Fix SQL Query for SearchTeam
#20844
Merged
Fix SQL Query for SearchTeam
#20844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Currently the function takes in the `UserID` option, but isn't being used within the SQL query. This patch fixes that by checking that only teams are being returned that the user belongs to. - Resolves go-gitea#20829
lunny
approved these changes
Aug 18, 2022
GiteaBot
added
the
lgtm/need 1
delvh
approved these changes
Aug 18, 2022
GiteaBot
added
lgtm/done
Co-authored-by: delvh <dev.lh@web.de>
|
And some unit tests seem to need an edit… |
|
Thanks for fixing this bug |
|
@delvh @lunny Please re-review again. Especially regarding this line: https://github.com/go-gitea/gitea/pull/20844/files#diff-3d84110fa93e421c3875fcd87a4732305131fc42b65d34d06a1b8e453bee3d80L342 This function is already specified to require organization admin in the router, so no need to specify only the teams that the user belong in |
delvh
approved these changes
Aug 18, 2022
Co-authored-by: delvh <dev.lh@web.de>
zeripath
approved these changes
Aug 18, 2022
|
Interesting CI failure: |
Gusted
pushed a commit
to Gusted/gitea
that referenced
this pull request
Aug 20, 2022
- Backport of go-gitea#20844 - Currently the function takes in the UserID option, but isn't being used within the SQL query. This patch fixes that by checking that only teams are being returned that the user belongs to. - Resolves go-gitea#20829
|
make lgtm work |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 22, 2022
* giteaofficial/main: update current stable version [skip ci] Updated translations via Crowdin Fix mirror address setting not working (go-gitea#20850) Support Proxy protocol (go-gitea#12527) Fix SQL Query for `SearchTeam` (go-gitea#20844) Double check CloneURL is acceptable (go-gitea#20869) Fix graceful doc (go-gitea#20883) Pad GPG Key ID with preceding zeroes (go-gitea#20878) [skip ci] Updated translations via Crowdin call builtinUnused() if internal SSH is disabled (go-gitea#20877) Don't open new page for ext wiki on same repository (go-gitea#20725) [skip ci] Updated translations via Crowdin Fix the mode of custom dir to 0700 in docker-rootless (go-gitea#20861) Fix UI mis-align for PR commit history (go-gitea#20845)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 28, 2022
- Currently the function takes in the `UserID` option, but isn't being used within the SQL query. This patch fixes that by checking that only teams are being returned that the user belongs to. Fix go-gitea#20829 Co-authored-by: delvh <dev.lh@web.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UserIDoption, but isn't being used within the SQL query. This patch fixes that by checking that only teams are being returned that the user belongs to.