Increase Content field size of gpg_key and public_key to MEDIUMTEXT (#20896) #20911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-gitea#20896) Backport go-gitea#20896 Unfortunately some keys are too big to fix within the 65535 limit of TEXT on MySQL this causes issues with these large keys. Therefore increase these fields to MEDIUMTEXT. Unfortunately the migration in go-gitea#20896 cannot be backported to 1.17 so affected users will have to use `gitea doctor recreate-table gpg_key public_key` Fix go-gitea#20894 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
pr/breaking
delvh
approved these changes
Aug 22, 2022
GiteaBot
added
the
lgtm/need 1
Gusted
approved these changes
Aug 22, 2022
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #20896
Unfortunately some keys are too big to fix within the 65535 limit of TEXT on MySQL
this causes issues with these large keys.
Therefore increase these fields to MEDIUMTEXT.
Fix #20894
Signed-off-by: Andrew Thornton art27@cantab.net
Technically this PR should contain a migration but the migration in #20896 cannot be backported to 1.17.
Affected users will have to use
gitea doctor recreate-table gpg_key public_keyOnly MySQL users will need to do this.