Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid frequent string2bytes conversions #20940

Merged
merged 2 commits into from
Aug 24, 2022
Merged

fix: avoid frequent string2bytes conversions #20940

merged 2 commits into from
Aug 24, 2022

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Aug 24, 2022

Fix #20939

Every time the pos moves, then whole string will be converted to bytes, when the data is huge, it will be very slow.

Related to #19990

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 24, 2022
@zeripath
Copy link
Contributor

It should be possible to further improve this by using a technique that will avoid the allocation of the []byte slice.

@zeripath zeripath added performance/speed performance issues with slow downs skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 24, 2022
@zeripath zeripath added this to the 1.18.0 milestone Aug 24, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 24, 2022
@zeripath zeripath merged commit 15b189b into go-gitea:main Aug 24, 2022
@zeripath
Copy link
Contributor

BTW There will be other performance improvements in this code.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 25, 2022
* upstream/main:
  Fix input.value attr for RequiredClaimName/Value (go-gitea#20946)
  Move some files into models' sub packages (go-gitea#20262)
  [skip ci] Updated translations via Crowdin
  docs[zh-cn]: Install on Kubernetes (go-gitea#20874)
  Return 404 NotFound if requested attachment does not exist (go-gitea#20886)
  Avoid frequent string2bytes conversions (go-gitea#20940)
@delvh
Copy link
Member

delvh commented Aug 28, 2022

How do you approve a PR 4 days after it has been merged?
Doesn't GitHub only allow to Submit a review then?

@lafriks
Copy link
Member

lafriks commented Aug 28, 2022

Yeah, I did not notice in GitHub mobile app it was already merged 😅

vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/speed performance issues with slow downs skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When there's a huge file, escapeStreamer.Text will be very slow
6 participants