Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include go.mod in gomod-check and rename to tidy-check #21025

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Include go.mod in gomod-check and rename to tidy-check #21025

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed28659
Include go.mod in gomod-check and rename to tidy-check
silverwind Sep 1, 2022
fef5085
Merge branch 'main' into tidycheck
techknowlogick Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ checks: checks-frontend checks-backend
checks-frontend: lockfile-check svg-check

.PHONY: checks-backend
checks-backend: gomod-check swagger-check swagger-validate
checks-backend: tidy-check swagger-check swagger-validate

.PHONY: lint
lint: lint-frontend lint-backend
Expand Down Expand Up @@ -388,9 +388,9 @@ tidy:
vendor: tidy
$(GO) mod vendor

.PHONY: gomod-check
gomod-check: tidy
@diff=$$(git diff go.sum); \
.PHONY: tidy-check
tidy-check: tidy
@diff=$$(git diff go.mod go.sum); \
if [ -n "$$diff" ]; then \
echo "Please run 'make tidy' and commit the result:"; \
echo "$${diff}"; \
Expand Down