Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop logging CheckPath returns error: context canceled #21064

Merged

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Sep 4, 2022

We should only log CheckPath errors if they are not simply due to context cancellation - and we should add a little more context to the error message.

Fix #20709

Signed-off-by: Andrew Thornton art27@cantab.net

We should only log CheckPath errors if they are not simply due to context cancellation.

Fix go-gitea#20709

Signed-off-by: Andrew Thornton <art27@cantab.net>
modules/git/repo_attribute.go Outdated Show resolved Hide resolved
services/gitdiff/gitdiff.go Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 4, 2022
Co-authored-by: delvh <dev.lh@web.de>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 4, 2022
@silverwind
Copy link
Member

Does it conflict with #20823?

@zeripath
Copy link
Contributor Author

zeripath commented Oct 5, 2022

@silverwind I guess it is orthogonal to #20823

@zeripath
Copy link
Contributor Author

zeripath commented Oct 7, 2022

Peeps this PR would remove a lot of confusing log messages. It would be good to get it merged

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 10, 2022
@zeripath zeripath merged commit 3ccebf7 into go-gitea:main Oct 10, 2022
@zeripath zeripath deleted the fix-20709-prevent-logging-context-cancelled branch October 10, 2022 20:54
zeripath added a commit to zeripath/gitea that referenced this pull request Oct 10, 2022
Backport go-gitea#21064

We should only log CheckPath errors if they are not simply due to
context cancellation - and we should add a little more context to the
error message.

Fix go-gitea#20709

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the backport/done All backports for this PR have been created label Oct 10, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 11, 2022
* upstream/main:
  Add user/organization code search (go-gitea#19977)
  Stop logging CheckPath returns error: context canceled (go-gitea#21064)
  Hook go-licenses into tidy again (go-gitea#21353)
  Fix missing left and right carets in TRANSLATORS (go-gitea#21397)
  Fix calls to i18n in templates (go-gitea#21394)
  Update JS dependencies and eslint config (go-gitea#21388)
  Allow creation of OAuth2 applications for orgs (go-gitea#18084)
  Fix typos in PullRequestMergeForm.vue header comment (go-gitea#21378)
  Use weighted algorithm for string matching when finding files in repo (go-gitea#21370)
  Bump playwright to 1.26.1 (go-gitea#21357)
  npm package registry support for `bin` (go-gitea#21372)
  Removed one extra whitespace in footer after "Template" (go-gitea#21364)
lunny pushed a commit that referenced this pull request Oct 11, 2022
Backport #21064

We should only log CheckPath errors if they are not simply due to
context cancellation - and we should add a little more context to the
error message.

Fix #20709

Signed-off-by: Andrew Thornton <art27@cantab.net>

Signed-off-by: Andrew Thornton <art27@cantab.net>
tyroneyeh pushed a commit to tyroneyeh/gitea that referenced this pull request Oct 24, 2022
… (go-gitea#21405)

Backport go-gitea#21064

We should only log CheckPath errors if they are not simply due to
context cancellation - and we should add a little more context to the
error message.

Fix go-gitea#20709

Signed-off-by: Andrew Thornton <art27@cantab.net>

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CheckPath returns error: context canceled
6 participants