Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing volume to test-e2e #21079

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Conversation

silverwind
Copy link
Member

Without it, the deps-backend step before is useless as go test will not see the files in GOPATH and re-download them.

@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Sep 5, 2022
@silverwind silverwind added this to the 1.18.0 milestone Sep 5, 2022
@silverwind silverwind changed the title Add missing volume dependency to test-e2e Add missing volume to test-e2e Sep 5, 2022
Without it, the deps-backend step before is useless as `go test` will
not see the files in GOPATH and re-download them.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 5, 2022
@silverwind
Copy link
Member Author

For some reason, it's still downloading:

https://drone.gitea.io/go-gitea/gitea/60161/4/6

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 5, 2022
@techknowlogick techknowlogick merged commit 7f6306c into go-gitea:main Sep 5, 2022
@silverwind silverwind deleted the voldep branch September 5, 2022 21:42
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 6, 2022
* upstream/main:
  Fix sub folder in repository missing add file dropdown (go-gitea#21069)
  [skip ci] Updated translations via Crowdin
  Add missing volume to test-e2e (go-gitea#21079)
  Fix delete user missed some comments (go-gitea#21067)
  Remove insecure flag from curl (go-gitea#21074)
  Update curl usage in API docs (go-gitea#21071)
  Move go-licenses to generate and separate generate into a frontend and backend component (go-gitea#21061)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants