Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uppercase ASCII alphabet in PyPI package names #21095

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Sep 6, 2022

The PyPI name regexp is too restrictive and only permits lowercase characters. This PR adjusts the regexp to add in support for uppercase characters.

Fix #21014

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 6, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 6, 2022
@zeripath
Copy link
Contributor

zeripath commented Sep 7, 2022

make lgtm work

@zeripath zeripath merged commit 8b8bdb3 into go-gitea:main Sep 7, 2022
@lunny
Copy link
Member

lunny commented Sep 8, 2022

Please send backport

zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 9, 2022
* upstream/main:
  Make the vscode clone link respect transport protocol (go-gitea#20557)
  Fix typo of issue template name (go-gitea#21117)
  [skip ci] Updated translations via Crowdin
  Fix pagination limit parameter problem (go-gitea#21109)
  Rewrite go license generator in go (go-gitea#21078)
  Allow uppercase ASCII alphabet in PyPI package names (go-gitea#21095)
  Fix various typos (go-gitea#21103)
  Update docs issue-pull-request-templates.zh-cn.md (go-gitea#21030)
  Upgrade the document about how to collect logs for systemd and docker (go-gitea#21101)
@KN4CK3R KN4CK3R deleted the patch-1 branch September 20, 2022 06:18
KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Sep 20, 2022
The PyPI name regexp is too restrictive and only permits lowercase characters. This PR adjusts the regexp to add in support for uppercase characters.

Fix go-gitea#21014
wxiaoguang pushed a commit that referenced this pull request Sep 20, 2022
Backport of #21095

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@6543 6543 added the backport/done All backports for this PR have been created label Oct 15, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/packages type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uppercase characters in pypi packages names are not allowed for upload
8 participants