Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher fidelity imports #21114

Closed
wants to merge 5 commits into from
Closed

Higher fidelity imports #21114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2a60256
Higher fidelity imports
techknowlogick Sep 8, 2022
22709c7
use meta information from yaml
techknowlogick Sep 9, 2022
ed3609e
Merge branch 'main' into process-transactions
techknowlogick Sep 9, 2022
234293f
nil check
techknowlogick Sep 27, 2022
ff78b08
Merge branch 'process-transactions' of github.com:techknowlogick/gite…
techknowlogick Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/migration/comment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,15 @@ type Commentable interface {
type Comment struct {
IssueIndex int64 `yaml:"issue_index"`
Index int64
CommentType int64
PosterID int64 `yaml:"poster_id"`
PosterName string `yaml:"poster_name"`
PosterEmail string `yaml:"poster_email"`
Created time.Time
Updated time.Time
Content string
Reactions []*Reaction
Meta map[string]interface{} // see models/issues/comment.go for fields in Comment struct
}

// GetExternalName ExternalUserMigrated interface
Expand Down
17 changes: 15 additions & 2 deletions services/migrations/gitea_uploader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,15 +462,28 @@ func (g *GiteaLocalUploader) CreateComments(comments ...*base.Comment) error {
if comment.Updated.IsZero() {
comment.Updated = comment.Created
}

if comment.CommentType == 0 {
// if type field is missing, then assume a normal comment
comment.CommentType = int64(issues_model.CommentTypeComment)
techknowlogick marked this conversation as resolved.
Show resolved Hide resolved
}
cm := issues_model.Comment{
IssueID: issue.ID,
Type: issues_model.CommentTypeComment,
Type: issues_model.CommentType(comment.CommentType),
Content: comment.Content,
CreatedUnix: timeutil.TimeStamp(comment.Created.Unix()),
UpdatedUnix: timeutil.TimeStamp(comment.Updated.Unix()),
}

switch issues_model.CommentType(comment.CommentType) {
case issues_model.CommentTypeLabel:
// TODO: add label to issue
case issues_model.CommentTypeAssignees:
// TODO: add assignee to issue
case issues_model.CommentTypeChangeTitle:
// TODO: change issue title
default:
}

if err := g.remapUser(comment, &cm); err != nil {
return err
}
Expand Down