Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Clone in VSCode link get updated correctly #21225

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

wxiaoguang
Copy link
Contributor

Follow #20557, fix #21224

The clone_script will update .js-clone-url and related elements (unfortunately it's not obvious in code and fragile), so it should be put after these elements.

@wxiaoguang wxiaoguang added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.17 labels Sep 21, 2022
@wxiaoguang wxiaoguang added this to the 1.18.0 milestone Sep 21, 2022
@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Sep 21, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 21, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 21, 2022
@wxiaoguang wxiaoguang merged commit d9bc688 into go-gitea:main Sep 21, 2022
@wxiaoguang wxiaoguang deleted the fix-clone-vsc branch September 21, 2022 11:51
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 22, 2022
* upstream/main:
  Use absolute links in feeds (go-gitea#21229)
  Prevent invalid behavior for file reviewing when loading more files (go-gitea#21230)
  Respect `REQUIRE_SIGNIN_VIEW` for packages (go-gitea#20873)
  Make Clone in VSCode link get updated correctly (go-gitea#21225)
  Configure golangci-lint to show all issues (go-gitea#21106)
  Fix user visible check (go-gitea#21210)
  Fix template bug of admin monitor (go-gitea#21208)
  Clarify that `ENABLE_SWAGGER` only influences the API docs, not the routes (go-gitea#21215)
  Enable fluid page layout on medium size viewports (go-gitea#21178)
  [API] teamSearch show teams with no members if user is admin (go-gitea#21204)
wxiaoguang added a commit that referenced this pull request Sep 23, 2022
Backport #21225, fix for #21128 (also in 1.17.3), close #21224

The indent was incorrect before, so this PR did some formatting work. 

Bypass Golang's template bug for JS string interpolation. And since
there are JS lint rules for templates, so the string interpolation is
also a must.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The js-clone-url-vsc element is located below the script
4 participants