-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HEAD fix to gitea doctor #21352
Merged
Merged
Add HEAD fix to gitea doctor #21352
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f98e882
Add HEAD fix to gitea doctor
clarfonthey a3bb8cf
Use symbolic-ref to get/set HEAD
clarfonthey 833af72
Merge branch 'main' into heads
zeripath 3bd7003
gofumpt
clarfonthey d76b9d4
Double-dashes
clarfonthey 49cfd55
Update modules/doctor/heads.go
wxiaoguang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
// Copyright 2022 The Gitea Authors. All rights reserved. | ||
// Use of this source code is governed by a MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package doctor | ||
|
||
import ( | ||
"context" | ||
|
||
repo_model "code.gitea.io/gitea/models/repo" | ||
"code.gitea.io/gitea/modules/git" | ||
"code.gitea.io/gitea/modules/log" | ||
) | ||
|
||
func synchronizeRepoHeads(ctx context.Context, logger log.Logger, autofix bool) error { | ||
numRepos := 0 | ||
numHeadsBroken := 0 | ||
numDefaultBranchesBroken := 0 | ||
numReposUpdated := 0 | ||
err := iterateRepositories(ctx, func(repo *repo_model.Repository) error { | ||
numRepos++ | ||
runOpts := &git.RunOpts{Dir: repo.RepoPath()} | ||
|
||
_, _, defaultBranchErr := git.NewCommand(ctx, "rev-parse", "--", repo.DefaultBranch).RunStdString(runOpts) | ||
|
||
head, _, headErr := git.NewCommand(ctx, "symbolic-ref", "--short", "HEAD").RunStdString(runOpts) | ||
|
||
// what we expect: default branch is valid, and HEAD points to it | ||
if headErr == nil && defaultBranchErr == nil && head == repo.DefaultBranch { | ||
return nil | ||
} | ||
|
||
if headErr != nil { | ||
numHeadsBroken++ | ||
} | ||
if defaultBranchErr != nil { | ||
numDefaultBranchesBroken++ | ||
} | ||
|
||
// if default branch is broken, let the user fix that in the UI | ||
if defaultBranchErr != nil { | ||
logger.Warn("Default branch for %s/%s doesn't point to a valid commit", repo.OwnerName, repo.Name) | ||
return nil | ||
} | ||
|
||
// if we're not autofixing, that's all we can do | ||
if !autofix { | ||
return nil | ||
} | ||
|
||
// otherwise, let's try fixing HEAD | ||
err := git.NewCommand(ctx, "symbolic-ref", "--", "HEAD", repo.DefaultBranch).Run(runOpts) | ||
if err != nil { | ||
logger.Warn("Failed to fix HEAD for %s/%s: %v", repo.OwnerName, repo.Name, err) | ||
return nil | ||
} | ||
numReposUpdated++ | ||
return nil | ||
}) | ||
if err != nil { | ||
logger.Critical("Error when fixing repo HEADs: %v", err) | ||
} | ||
|
||
if autofix { | ||
logger.Info("Out of %d repos, HEADs for %d are now fixed and HEADS for %d are still broken", numRepos, numReposUpdated, numDefaultBranchesBroken+numHeadsBroken-numReposUpdated) | ||
} else { | ||
if numHeadsBroken == 0 && numDefaultBranchesBroken == 0 { | ||
logger.Info("All %d repos have their HEADs in the correct state") | ||
} else { | ||
if numHeadsBroken == 0 && numDefaultBranchesBroken != 0 { | ||
logger.Critical("Default branches are broken for %d/%d repos", numDefaultBranchesBroken, numRepos) | ||
} else if numHeadsBroken != 0 && numDefaultBranchesBroken == 0 { | ||
logger.Warn("HEADs are broken for %d/%d repos", numHeadsBroken, numRepos) | ||
} else { | ||
logger.Critical("Out of %d repos, HEADS are broken for %d and default branches are broken for %d", numRepos, numHeadsBroken, numDefaultBranchesBroken) | ||
} | ||
} | ||
} | ||
|
||
return err | ||
} | ||
|
||
func init() { | ||
Register(&Check{ | ||
Title: "Synchronize repo HEADs", | ||
Name: "synchronize-repo-heads", | ||
IsDefault: true, | ||
Run: synchronizeRepoHeads, | ||
Priority: 7, | ||
}) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether the Critical is necessary here. IMO Critical means something wrong seriously and will cause the program stop from working.
Generally LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider the default branch not pointing to any commit a critical issue, although I guess this could happen if you have repos without commits. Not sure how we distinguish that though.