Format date range in in activity page according to locale #21387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #21380 Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
|
It's not the proper way to do i18n for date & time. As a quick fix, the ISO format "2000-01-02" could be better, everyone could understand it. As a complete fix, the i18n module should have the ability to translate date & time flexibly for all languages, not just replacing the month. |
GiteaBot
added
the
lgtm/need 2
|
At the moment, Gitea's i18n module is also at the early stage, which couldn't properly handle all needs for i18n. I can not think about a feasible plan for the complete solution before Gitea's i18n module gets improved significantly. That's why I also mentioned a "quick fix", the ISO format is widely used and easy to understand, I can L-G-T-M for the quick fix 😁 |
lafriks
pushed a commit
that referenced
this pull request
Oct 12, 2022
…ity page (#21410) # Description Previously, to make the date range understood by all, we used the format "2006-01-02" for the dates as it's locale-generic. This commit changes the rendering logic. Instead of rendering the date on the server, we send a formatted computer-readable timestamp. The client's javascript then renders it according to the user's locale. This approach is reusable across the codebase, any `<time></time>` tag with the data-format="date" attribute would get rendered according to the user's chosen locale. ## Previous View  ## New View ### English  ### French  ### Portuguese  ### Italian  # References * #21380 * #21387 * #21396 Inspiration: I think either differentiating by class, or probably better by a custom attribute such as `data-format` or similar, is the best course of action. _Originally posted by @delvh in #21396 (comment) Resolves #21380 Signed-off-by: Yarden Shoham <hrsi88@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21380
Before this PR, the date range on the activity page was hardcoded in English. This PR adds functionality so that the date range would respect the chosen locale.
For example:
