Display total commit count in hook message

[KN4CK3R]

Fixes #21379

The commits are capped by setting.UI.FeedMaxCommitNum so len(commits) is not the correct number. So this PR adds a new TotalCommits field.

Example of MS Teams:

[KN4CK3R]

I changed the link text because the displayed commit ids are not the same as in CompareURL.

[KN4CK3R]

That's a special character my editor warned me about.

[silverwind]

Yeah, that was not a ASCII colon.

[TheBrokenRail]

Does this also fix the "X new commits" link on the Discord embed also only showing 5 commits?

[KN4CK3R]

Yes, all hook types show the correct commit count. But by default only 5 commits are displayed. So:

12 new commits:
commit1
commit2
commit3
commit4
commit5

[TheBrokenRail]

My question isn't about the label. At least on Discord, the "X new commits" text is also a link to a page comparing the latest commit with the last commit before the push.

At least it should be, when I tested it, it only compared the past 5 commits in the push.

[KN4CK3R]

I think the url is still wrong. There are two cases.

For mirror commits the url should be correct because the commits are not used:

gitea/services/mirror/mirror_pull.go

Lines 494 to 499 in 6a6dc97

	theCommits := repo_module.GitToPushCommits(commits)
	if len(theCommits.Commits) > setting.UI.FeedMaxCommitNum {
	theCommits.Commits = theCommits.Commits[:setting.UI.FeedMaxCommitNum]
	}
	theCommits.CompareURL = m.Repo.ComposeCompareURL(oldCommitID, newCommitID)

For normal commits the url is wrong because oldCommitID is received from the shrinked commits list.

gitea/services/repository/push.go

Lines 222 to 251 in 6a6dc97

	if len(commits.Commits) > setting.UI.FeedMaxCommitNum {
	commits.Commits = commits.Commits[:setting.UI.FeedMaxCommitNum]
	}
	oldCommitID := opts.OldCommitID
	if oldCommitID == git.EmptySHA && len(commits.Commits) > 0 {
	oldCommit, err := gitRepo.GetCommit(commits.Commits[len(commits.Commits)-1].Sha1)
	if err != nil && !git.IsErrNotExist(err) {
	log.Error("unable to GetCommit %s from %-v: %v", oldCommitID, repo, err)
	}
	if oldCommit != nil {
	for i := 0; i < oldCommit.ParentCount(); i++ {
	commitID, _ := oldCommit.ParentID(i)
	if !commitID.IsZero() {
	oldCommitID = commitID.String()
	break
	}
	}
	}
	}
	if oldCommitID == git.EmptySHA && repo.DefaultBranch != branch {
	oldCommitID = repo.DefaultBranch
	}
	if oldCommitID != git.EmptySHA {
	commits.CompareURL = repo.ComposeCompareURL(oldCommitID, opts.NewCommitID)
	} else {
	commits.CompareURL = ""
	}

This should be fixed if the shrinking takes place after the url generation.

[TheBrokenRail]

Was the URL bug fixed before merging? Or will that be a separate PR?

[KN4CK3R]

I will create a different PR for that.

[wxiaoguang]

--> Fix incorrect notification commit url #21479

I have proposed one.