Use own Go version instead of hardcoded 1.17 for make fmt

[yardenshoham]

We should make sure we're using the same version across the codebase.

• We upgraded in Use Golang 1.18 for Gitea 1.17 release #19918 but forgot about the following line

  gitea/build/code-batch-process.go

  Line 273 in 6bb6a10

  cmdErrors = append(cmdErrors, passThroughCmd("go", append([]string{"run", os.Getenv("GOFUMPT_PACKAGE"), "-extra", "-lang", "1.17"}, substArgs...)))

[silverwind]

This whole code-batch-process.go thing seems rather insane to me. I'd rather have us run gofumpt directly which will work much better in regards to editor integrations and such.

The canonical way to specify go version to gofumpt is through -lang, so I would replicate that. SeeMIN_GO_VERSION in the Makefile.

go run mvdan.cc/gofumpt@latest --help |& grep lang
  -lang       str    target Go version in the form "1.X" (default from go.mod)

[wxiaoguang]

I do not like the code-batch-process.go either, but at that time it's needed for Windows developers to run make fmt (#14438)

Not sure whether the situation (eco-system) has been better now, if the code-batch-process.go is unnecessary any more, remove it.

• Remove broken and useless file in build #20952 (comment)

[6543]

well i dont understand why one would programm on windows, but there are always the one who are forced to do so ... :/

[wxiaoguang]

It seems that the only need for the code-batch-process is misspell, which still takes a file list as arguments.

I think we can get this PR at the moment and refactor the building system later, remove out-dated tools.

---

Update:

Actually, after

• chore(lint): use golangci-lint to call revive and misspell checker. #18145

The misspell is never used, the only sub-command call to code-batch-format is gitea-fmt, no misspell anymore.

[wxiaoguang]

The change looks good to me.

But I have a feeling that the code-batch-process will be removed soon and the Makefile will call the gitea-fmt directly without this wrapper.

[yardenshoham]

Sounds good to me, until then we can land thia

[6543]

🚀

[zeripath]

It seems that the only need for the code-batch-process is misspell, which still takes a file list as arguments.

It also runs the gitea import formatter.

[wxiaoguang]

It seems that the only need for the code-batch-process is misspell, which still takes a file list as arguments.

It also runs the gitea import formatter.

Yup, I meant "which still takes a file list as arguments.", only the old misspell command needs it.

For gitea import formatter, it could be simplified to scan the source directory directly, no need for the code-batch-process wrapper anymore.

I think it's time to drop the code-batch-process wrapper (I will take the work)

[wxiaoguang]

--> Remove code-batch-process #21471