Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve code quality #21462

Closed
wants to merge 11 commits into from
Closed

improve code quality #21462

wants to merge 11 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 14, 2022

some minor fixes

@6543 6543 added this to the 1.18.0 milestone Oct 14, 2022
@6543 6543 mentioned this pull request Oct 14, 2022
Merged
@6543 6543 added the type/bug label Oct 14, 2022
delvh
delvh reviewed Oct 14, 2022
View reviewed changes
modules/git/repo_commit.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 14, 2022
6543
6543 commented Oct 15, 2022
View reviewed changes
modules/git/repo_commit.go Outdated Show resolved Hide resolved
6543
6543 commented Oct 15, 2022
View reviewed changes
modules/git/repo_commit.go Outdated Show resolved Hide resolved
6543 added a commit to 6543-forks/gitea that referenced this pull request Oct 15, 2022
@6543
improve code quality (go-gitea#21462) (go-gitea#21463)
f1830e2 
Backport go-gitea#21462
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Oct 15, 2022 •
edited
Loading

IIRC --end-of-options requires Git 2.24 ? But Gitea declares it only requires Git 2.0

wxiaoguang
wxiaoguang reviewed Oct 15, 2022
View reviewed changes
modules/git/commit.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Oct 15, 2022

@wxiaoguang bumped

lunny
lunny requested changes Oct 15, 2022
View reviewed changes
modules/git/git.go Show resolved Hide resolved
@delvh
Copy link
Member

delvh commented Oct 15, 2022

Well… Now that we have the alternative merged, isn't this PR obsolete?

@6543 6543 closed this Oct 15, 2022
@6543 6543 deleted the some-nit branch October 15, 2022 11:05
@6543 6543 mentioned this pull request Oct 15, 2022
Merged
@6543 6543 removed this from the 1.18.0 milestone Oct 15, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh left review comments

@noerw noerw noerw left review comments

@wxiaoguang wxiaoguang wxiaoguang left review comments

@zeripath zeripath zeripath left review comments

@lunny lunny lunny requested changes

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@6543 @wxiaoguang @delvh @lunny @zeripath @noerw @GiteaBot