Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

probe if sha before exec git #21467

Merged
merged 10 commits into from
Oct 17, 2022
Merged

probe if sha before exec git #21467

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c715bca
probe if sha before exec git
6543 Oct 15, 2022
9d27169
more test coverage
6543 Oct 15, 2022
d2b4aa9
IsValidSHAPattern is enouth
6543 Oct 15, 2022
c5be03b
Merge branch 'main' into improve-git
6543 Oct 15, 2022
f0cf584
Merge branch 'main' into improve-git
6543 Oct 15, 2022
3823bf2
Merge branch 'main' into improve-git
lunny Oct 16, 2022
52ba255
Merge branch 'main' into improve-git
wxiaoguang Oct 16, 2022
835b900
Merge branch 'main' into improve-git
6543 Oct 16, 2022
346f590
Merge branch 'main' into improve-git
lunny Oct 17, 2022
79c3fb4
Merge branch 'main' into improve-git
6543 Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/git/repo_commit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ func (repo *Repository) searchCommits(id SHA1, opts SearchCommitsOptions) ([]*Co
if len(opts.Keywords) > 0 {
for _, v := range opts.Keywords {
// ignore anything below 4 characters as too unspecific
if len(v) >= 4 {
if len(v) >= 4 && IsValidSHAPattern(v) {
lunny marked this conversation as resolved.
Show resolved Hide resolved
// create new git log command with 1 commit limit
hashCmd := NewCommand(repo.Ctx, "log", "-1", prettyLogFormat)
// add previous arguments except for --grep and --all
Expand Down