Remove deleted repos from searchresult #21512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents a 500 result, because null pointer exceptions in rendering the template. This happends bc the repoId is not in the repoMap because it is delete (or archived?)
This comment was marked as duplicate.
This comment was marked as duplicate.
GiteaBot
added
the
lgtm/need 2
lunny
added
type/enhancement
|
The index in fact will be deleted in index notification system. But it will take some time. So this will be a temporary resolution. |
lunny
approved these changes
Oct 19, 2022
GiteaBot
added
lgtm/need 1
You mean temporary as in removing this fix, or temporary as in the time that the index contains non existing repoIDs? |
delvh
approved these changes
Oct 20, 2022
GiteaBot
added
lgtm/done
6543
added
type/bug
and removed
type/enhancement
|
make L-G-T-M work. |
|
Please send backport |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 24, 2022
* upstream/main:
adapt README_{Country}.md stype name in localizedExtensions (go-gitea#21486)
dump: Add option to skip index dirs (go-gitea#21501)
Use recommended vscode configuration in gitpod environments (go-gitea#21537)
Expand "Go to File" button again, fix 'Add File' margin (go-gitea#21543)
Add yardenshoham to maintainers (go-gitea#21566)
Refactor git command arguments and make all arguments to be safe to be used (go-gitea#21535)
Update binding to fix bugs (go-gitea#21556)
Link mentioned user in markdown only if they are visible to viewer (go-gitea#21554)
Require authentication for OAuth token refresh (go-gitea#21421)
CSS color enhancements (go-gitea#21534)
Allow package version sorting (go-gitea#21453)
Add link to user profile in markdown mention only if user exists (go-gitea#21533)
Update milestone counters when issue is deleted (go-gitea#21459)
Prevent Authorization header for presigned LFS urls (go-gitea#21531)
Remove deleted repos from searchresult (go-gitea#21512)
Remove unnecessary debug log (go-gitea#21536)
Added check for disabled Packages (go-gitea#21540)
Decouple HookTask from Repository (go-gitea#17940)
Add color previews in markdown (go-gitea#21474)
Fix generating compare link (go-gitea#21519)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a 500 response, because null pointer exceptions in rendering the template.
This happends bc the repoId is not in the repoMap because it is delete
fix #19076