Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert unrelated changes for SMTP auth #21767

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Revert unrelated changes for SMTP auth #21767

merged 2 commits into from
Nov 10, 2022

Conversation

wxiaoguang
Copy link
Contributor

The purpose of #18982 is to improve the SMTP mailer, but there were some unrelated changes made to the SMTP auth in d60c438

This PR reverts these unrelated changes, fix #21744

@wxiaoguang wxiaoguang added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. outdated/backport/v1.18 This PR should be backported to Gitea 1.18 labels Nov 10, 2022
@wxiaoguang wxiaoguang added this to the 1.19.0 milestone Nov 10, 2022
This was referenced Nov 10, 2022
Closed
Merged
@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Nov 10, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 10, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 10, 2022
@techknowlogick
Copy link
Member

cc: @clarfonthey

techknowlogick pushed a commit that referenced this pull request Nov 10, 2022
@wxiaoguang @lunny
Revert unrelated changes for SMTP auth (#21767) (#21768)
3aacc9b 
Backport #21767

The purpose of #18982 is to improve the SMTP mailer, but there were some
unrelated changes made to the SMTP auth in
d60c438

This PR reverts these unrelated changes, fix #21744

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit fb704f6 into go-gitea:main Nov 10, 2022
@wxiaoguang wxiaoguang deleted the fix-smtp-auth branch November 11, 2022 02:01
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 11, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f152eb2 
* giteaofficial/main:
  Revert unrelated changes for SMTP auth (go-gitea#21767)
  Init git module before database migration (go-gitea#21764)
  Extract updateSession function to reduce repetition (go-gitea#21735)
  Fix dashboard ignored system setting cache (go-gitea#21621)
  Add .dockerignore (go-gitea#21753)
fsologureng pushed a commit to fsologureng/gitea that referenced this pull request Nov 11, 2022
@wxiaoguang @fsologureng
Revert unrelated changes for SMTP auth (go-gitea#21767)
d2e5120 
The purpose of go-gitea#18982 is to improve the SMTP mailer, but there were some
unrelated changes made to the SMTP auth in
go-gitea@d60c438

This PR reverts these unrelated changes, fix go-gitea#21744
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.18 This PR should be backported to Gitea 1.18 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.

SMTP-Auth broken in gitea 1.18.0+rc0
5 participants
@wxiaoguang @techknowlogick @lunny @delvh @GiteaBot