Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore issue template with a special name #21830

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Ignore issue template with a special name #21830

merged 2 commits into from
Nov 16, 2022

Conversation

wolfogre
Copy link
Member

A file in ISSUE_TEMPLATE with the name config.yml shouldn't be treated as a YAML template, it's for configuring the template chooser.

The old code tried to ignore the file, but it didn't work, caused by #20987. That's why the warning is displayed:

image

Note that this PR is not an implementation of config.yml, there will be another one to do it.

@wolfogre wolfogre added type/bug outdated/backport/v1.18 This PR should be backported to Gitea 1.18 labels Nov 16, 2022
@wolfogre wolfogre added this to the 1.19.0 milestone Nov 16, 2022
@wolfogre wolfogre changed the title Ignore issue templates with a special name Ignore issue template with a special name Nov 16, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 16, 2022
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 16, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 16, 2022
@lunny lunny merged commit 92dd247 into go-gitea:main Nov 16, 2022
@wolfogre wolfogre added the backport/done All backports for this PR have been created label Nov 16, 2022
techknowlogick pushed a commit that referenced this pull request Nov 16, 2022
Backport #21830.

A file in `ISSUE_TEMPLATE` with the name `config.yml` shouldn't be
treated as a YAML template, it's for [configuring the template
chooser](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser).

The old code tried to ignore the file, but it didn't work, caused by
#20987. That's why the warning is displayed:

<img width="415" alt="image"

src="https://user-images.githubusercontent.com/9418365/202094067-804c42fe-0e9e-4fc5-bf01-d95fa336f54f.png">

Note that this PR is not an implementation of `config.yml`, there will
be another one to do it.
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 17, 2022
* giteaofficial/main:
  Tweak katex options (go-gitea#21828)
  Ignore issue template with a special name (go-gitea#21830)
fsologureng pushed a commit to fsologureng/gitea that referenced this pull request Nov 22, 2022
A file in `ISSUE_TEMPLATE` with the name `config.yml` shouldn't be
treated as a YAML template, it's for [configuring the template
chooser](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser).

The old code tried to ignore the file, but it didn't work, caused by
go-gitea#20987. That's why the warning is displayed:

<img width="415" alt="image"
src="https://user-images.githubusercontent.com/9418365/202094067-804c42fe-0e9e-4fc5-bf01-d95fa336f54f.png">

Note that this PR is not an implementation of `config.yml`, there will
be another one to do it.
@wolfogre wolfogre mentioned this pull request Dec 3, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.18 This PR should be backported to Gitea 1.18 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants