Correct the fallbacks for mailer configuration #21945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately the fallback configuration code for [mailer] that were added in go-gitea#18982 are incorrect. When you read a value from an ini section that key is added. This leads to a failure of the fallback mechanism. Further there is also a spelling mistake in the startTLS configuration. This PR restructures the mailer code to first map the deprecated settings on to the new ones - and then use ini.MapTo to map those on to the struct with additional validation as necessary. Ref go-gitea#21744 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
outdated/backport/v1.18
wxiaoguang
approved these changes
Nov 26, 2022
GiteaBot
added
the
lgtm/need 1
a1012112796
approved these changes
Nov 27, 2022
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #21945 +/- ##
==========================================
- Coverage 48.19% 48.14% -0.06%
==========================================
Files 1037 1037
Lines 141359 141353 -6
==========================================
- Hits 68128 68051 -77
- Misses 65098 65162 +64
- Partials 8133 8140 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Nov 27, 2022
Backport go-gitea#21945 Unfortunately the fallback configuration code for [mailer] that were added in go-gitea#18982 are incorrect. When you read a value from an ini section that key is added. This leads to a failure of the fallback mechanism. Further there is also a spelling mistake in the startTLS configuration. This PR restructures the mailer code to first map the deprecated settings on to the new ones - and then use ini.MapTo to map those on to the struct with additional validation as necessary. Ref go-gitea#21744 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
that referenced
this pull request
Nov 27, 2022
Backport #21945 Unfortunately the fallback configuration code for [mailer] that were added in #18982 are incorrect. When you read a value from an ini section that key is added. This leads to a failure of the fallback mechanism. Further there is also a spelling mistake in the startTLS configuration. This PR restructures the mailer code to first map the deprecated settings on to the new ones - and then use ini.MapTo to map those on to the struct with additional validation as necessary. Ref #21744 Signed-off-by: Andrew Thornton <art27@cantab.net>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 29, 2022
* giteaofficial/main: Use random bytes to generate access token (go-gitea#21959) Replace fmt.Sprintf with hex.EncodeToString (go-gitea#21960) Implement FSFE REUSE for golang files (go-gitea#21840) Correct the fallbacks for mailer configuration (go-gitea#21945) [skip ci] Updated licenses and gitignores Fix typos (go-gitea#21947) Fix markdown anchor re-clicking (go-gitea#21931) Prevent NPE if trying to restore an already restored deleted branch (go-gitea#21940) add rel="me" to org.website link (go-gitea#21941)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the fallback configuration code for [mailer] that were added in #18982 are incorrect. When you read a value from an ini section that key is added. This leads to a failure of the fallback mechanism. Further there is also a spelling mistake in the startTLS configuration.
This PR restructures the mailer code to first map the deprecated settings on to the new ones - and then use ini.MapTo to map those on to the struct with additional validation as necessary.
Ref #21744
Signed-off-by: Andrew Thornton art27@cantab.net