Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't return error if IsErrUserNotExist #22353

Closed
wants to merge 1 commit into from
Closed

Shouldn't return error if IsErrUserNotExist #22353

wants to merge 1 commit into from

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Jan 6, 2023

Shouldn't return an error and stop verifing if the error IsErrUserNotExist.

Related to #22119.

@wolfogre wolfogre added this to the 1.19.0 milestone Jan 6, 2023
@wolfogre wolfogre requested review from lunny and KN4CK3R January 6, 2023 03:30
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 6, 2023
@wolfogre wolfogre added backport/v1.17 outdated/backport/v1.18 This PR should be backported to Gitea 1.18 labels Jan 6, 2023
@wolfogre wolfogre closed this Jan 6, 2023
@wolfogre
Copy link
Member Author

wolfogre commented Jan 6, 2023

Looks like it should return an error and stop verifing if the error IsErrUserNotExist.

@zeripath zeripath removed backport/v1.17 outdated/backport/v1.18 This PR should be backported to Gitea 1.18 labels Jan 13, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants