Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't replace err variable in nested check (#22416) #22436

Closed
wants to merge 2 commits into from
Closed

fix: don't replace err variable in nested check (#22416) #22436

wants to merge 2 commits into from

Conversation

jolheiser
Copy link
Member

Backport #22416

@jolheiser
fix: don't replace err variable in nested check (go-gitea#22416)
b552ec2 
We can use `:=` to make `err` local to the if-scope instead of
overwriting the `err` in outer scope.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser added type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Jan 13, 2023
@jolheiser jolheiser added this to the 1.18.1 milestone Jan 13, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 13, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2023
@lunny
Copy link
Member

lunny commented Jan 14, 2023

#22425 has resolved the problem, I think this could be closed.

@lunny lunny closed this Jan 14, 2023
@zeripath zeripath removed this from the 1.18.1 milestone Jan 17, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jolheiser @lunny @delvh @zeripath @GiteaBot