Consume hcaptcha and pwn deps #22610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
jolheiser
commented
Jan 26, 2023
Comment on lines
+61
to
+66
| // Checking for a "good" password isn't going to be perfect, but we can give it a good try | ||
| // with hopefully minimal error. Try five times? | ||
| var good bool | ||
| var pw string | ||
| for idx := 0; idx <= 5; idx++ { | ||
| pw = testPassword() |
There was a problem hiding this comment.
This wasn't an ideal test then, and it isn't an ideal test now. Open to suggestions for this.
GiteaBot
added
the
lgtm/need 2
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
zeripath
approved these changes
Jan 27, 2023
GiteaBot
added
lgtm/need 1
|
I think we should clarify which modules we should merge into Gitea and which we should depends on third-party on documentation. My idea is depending on third-party moudules ASAP if it's mature and well mantained. |
|
I briefly looked, but admittedly not very hard, as these are fairly simple APIs. That being said, these are largely equivalent to their module counterpart. I just wanted to increase bus factor, I'm not against swapping them in the future if we find a better library elsewhere. |
lunny
approved these changes
Jan 29, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
🎺 🤖 |
lunny
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 30, 2023
* upstream/main: Add support for commit cross references (go-gitea#22645) Fix missing message in git hook when pull requests disabled on fork (go-gitea#22625) Check quota limits for container uploads (go-gitea#22450) Consume hcaptcha and pwn deps (go-gitea#22610) Issues: add Project filter to issues list and search (go-gitea#22544) Improve accessibility of navigation bar and footer (go-gitea#22635) Support system hook API (go-gitea#14537) Improve checkIfPRContentChanged (go-gitea#22611)
delvh
added
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just consumes the hcaptcha and haveibeenpwned modules directly into Gitea.
Nothing else uses them, so I figured they would be better off in the main repo rather than sitting stale in another repo.
Bringing them into the main repo will help keep eyes on them and also notify us if any of the testing starts failing (as I noticed the hcaptcha testing has changed since I made the original module for secret keys).
Note that the modules were made to be libraries, so copying them here more than likely has some more code than is needed directly by Gitea.
I'm not opposed to trimming it down, but as a first pass I just wanted to get them in here.
Also let this serve as a notice that I'm fine with transferring my license (which was already MIT) from my own name to "The Gitea Authors".