Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects: rename Board to Column in interface and improve consistency #22767

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

brechtvl
Copy link
Contributor

@brechtvl brechtvl commented Feb 5, 2023

What is called a board now is really a column on a project board. This changes just the naming in the interface and leaves the underlying implementation unchanged.

Further this improves consistency of the projects interface in a few ways:

  • Consistent title case for titles, buttons and menu items
  • Use just Column instead of Project Column consistently
  • Fix some wrong plural names
  • Consistent color of cancel and submit buttons in forms
  • Fix inconsistent rendering of template field in new project

@brechtvl
Copy link
Contributor Author

brechtvl commented Feb 5, 2023

I started fixing various capitalization inconsistencies and then noticed the plan in #20985 is to rename boards to columns. So I decided to do that here as well so it matches what we want it to look like in the end.

That PR however has been stalled for a bit, and I don't know if it would be acceptable to merge just the interface side renaming or not.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 5, 2023
What is called a board now is really a column on a project board. This changes
just the naming in the interface and leaves the underlying implementation
unchanged.

Further this improves consistency of the projects interface in a few ways:
* Consistent title case for titles, buttons and menu items
* Use just Column instead of Project Column consistently
* Fix some wrong plural names
* Consistent color of cancel and submit buttons in forms
* Fix inconsistent rendering of template field in new project
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

Merging #22767 (7f3e8d8) into main (df789d9) will increase coverage by 0.00%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main   #22767   +/-   ##
=======================================
  Coverage   47.29%   47.29%           
=======================================
  Files        1111     1111           
  Lines      149398   149408   +10     
=======================================
+ Hits        70656    70668   +12     
- Misses      70350    70354    +4     
+ Partials     8392     8386    -6     
Impacted Files Coverage Δ
modules/util/io.go 73.68% <0.00%> (-21.06%) ⬇️
modules/queue/queue_disk.go 60.00% <0.00%> (-3.34%) ⬇️
modules/queue/queue_bytefifo.go 50.18% <0.00%> (-2.89%) ⬇️
services/pull/comment.go 62.96% <0.00%> (-2.78%) ⬇️
routers/api/v1/repo/pull.go 49.71% <0.00%> (+0.16%) ⬆️
modules/queue/workerpool.go 55.00% <0.00%> (+0.71%) ⬆️
models/repo/repo.go 65.54% <0.00%> (+0.72%) ⬆️
services/pull/check.go 29.29% <0.00%> (+1.17%) ⬆️
services/pull/pull.go 43.51% <0.00%> (+1.26%) ⬆️
models/issues/pull_list.go 67.96% <0.00%> (+2.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Feb 5, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 5, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Feb 24, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2023
@techknowlogick
Copy link
Member

LGTM, could you resolve conflicts?

@techknowlogick techknowlogick merged commit 843f811 into go-gitea:main Feb 24, 2023
@eeyrjmr
Copy link
Contributor

eeyrjmr commented Feb 25, 2023

#20985 sort of does this

zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 27, 2023
* giteaofficial/main:
  Revert "[skip ci] Updated translations via Crowdin" (go-gitea#23167)
  [skip ci] Updated translations via Crowdin
  Return 404 instead of 403 if user can not access the repo (go-gitea#23155)
  [skip ci] Updated licenses and gitignores
  Fix secrets overview page missing from docs sidebar (go-gitea#23143)
  Add "Reviewed by you" filter for pull requests (go-gitea#22927)
  Projects: rename Board to Column in interface and improve consistency (go-gitea#22767)
  Fix DBConsistency checks on MSSQL (go-gitea#23132)
  Add pagination for dashboard and user activity feeds (go-gitea#22937)
  Update go.mod dependencies (go-gitea#23126)
  Show empty repos in Admin Repository Management page (go-gitea#23114)
  Redirect to the commit page after applying patch (go-gitea#23056)
  Bump go.etcd.io/bbolt and blevesearch deps (go-gitea#23062)
  Fix height for sticky head on large screen on PR page (go-gitea#23111)
@brechtvl brechtvl deleted the blender-project-ui branch March 11, 2023 11:28
lunny pushed a commit that referenced this pull request Mar 12, 2023
In #22767, we changed the class of `Edit Column` button from `red` to
`primary`
But `red` is used to find this button in js.....

---------

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: zeripath <art27@cantab.net>
@lunny lunny mentioned this pull request Mar 25, 2023
9 tasks
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants