-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid issues in project boards #22865
Fix invalid issues in project boards #22865
Conversation
There are still some bugs now. I will fix them later. |
It seems that it works well now. |
I made an mistake, it is necessary to check |
improve project names and icons in create/view/list issue page improve project names in issue badge redirect to origin page after edit an project
I'm not sure if this is solved via this PR already but please check out this important related comment (privacy critical bug): |
Ok, seams like this might still be an open task/bug to fix if I read this comment right: |
Is there a chance to have the conlficts fixed? |
I will try to, but I'm afraid maybe almost all of them are fixed. |
Need to check it carefully, as almost all changes are almost one year ago. |
…blic indifidual repo)
Reviewed this PR again, and I think this PR can be two.
|
- Do an access check when loading issues for a project column, currently this is not done and exposes the title, labels and existence of a private issue that the viewer of the project board may not have access to. - The number of issues cannot be calculated in a efficient manner and stored in the database because their number may vary depending on the visibility of the repositories participating in the project. The previous implementation used the pre-calculated numbers stored in each project, which did not reflect that potential variation. - The code is derived from go-gitea/gitea#22865
- Do an access check when loading issues for a project column, currently this is not done and exposes the title, labels and existence of a private issue that the viewer of the project board may not have access to. - The number of issues cannot be calculated in a efficient manner and stored in the database because their number may vary depending on the visibility of the repositories participating in the project. The previous implementation used the pre-calculated numbers stored in each project, which did not reflect that potential variation. - The code is derived from go-gitea/gitea#22865 (cherry picked from commit 2193afaeb9954a5778f5a47aafd0e6fbbf48d000)
- Do an access check when loading issues for a project board, currently this is not done and exposes the title, labels and existence of a private issue that the viewer of the project board may not have access to. - The number of issues cannot be calculated in a efficient manner and stored in the database because their number may vary depending on the visibility of the repositories participating in the project. The previous implementation used the pre-calculated numbers stored in each project, which did not reflect that potential variation. - The code is derived from go-gitea/gitea#22865 (cherry picked from commit 2193afaeb9954a5778f5a47aafd0e6fbbf48d000)
- Do an access check when loading issues for a project column, currently this is not done and exposes the title, labels and existence of a private issue that the viewer of the project board may not have access to. - The number of issues cannot be calculated in a efficient manner and stored in the database because their number may vary depending on the visibility of the repositories participating in the project. The previous implementation used the pre-calculated numbers stored in each project, which did not reflect that potential variation. - The code is derived from go-gitea/gitea#22865 (cherry picked from commit 2193afaeb9954a5778f5a47aafd0e6fbbf48d000)
Fixes #22860
Latest Edit: 2023/04/26)
Fixed:
addUpdateIssueProject
. (Which will make user project unselectable in a issue)Todo in future:
New Issue
button in a usertype project (related to Organization-wide issues #23827)