Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a11y for repo topic management #23346

Closed
wants to merge 32 commits into from
Closed

Fix a11y for repo topic management #23346

wants to merge 32 commits into from

Commits on Mar 7, 2023

  1. fix

    @wxiaoguang
    wxiaoguang committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    902be92 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-repo-topic-edit

    @wxiaoguang
    wxiaoguang authored Mar 7, 2023
    Configuration menu
    Copy the full SHA
    a42186e View commit details
    Browse the repository at this point in the history

  3. add aria attributes to delete icon

    @wxiaoguang
    wxiaoguang committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    c379fc5 View commit details
    Browse the repository at this point in the history

  4. make "delete icon button" slightly larger to be easier to click on mo… 

    …bile
    @wxiaoguang
    wxiaoguang committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    5dd48bb View commit details
    Browse the repository at this point in the history

  5. fix lint

    @wxiaoguang
    wxiaoguang committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    25f993b View commit details
    Browse the repository at this point in the history

  6. use exactly the same markup for labels

    @wxiaoguang
    wxiaoguang committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    fa2fa02 View commit details
    Browse the repository at this point in the history

  7. add more comments

    @wxiaoguang
    wxiaoguang committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    77ee1f1 View commit details
    Browse the repository at this point in the history

  8. use svg, fine tune styles

    @wxiaoguang
    wxiaoguang committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    5e9aa1e View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Merge branch 'main' into fix-repo-topic-edit

    @wxiaoguang
    wxiaoguang authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    93a2d40 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-repo-topic-edit

    @wxiaoguang
    wxiaoguang authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    b3b89a6 View commit details
    Browse the repository at this point in the history

  3. title: Remove topic "%s"

    @wxiaoguang
    wxiaoguang committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    a1e35b4 View commit details
    Browse the repository at this point in the history

  4. fix aria-label

    @wxiaoguang
    wxiaoguang committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    02c65fe View commit details
    Browse the repository at this point in the history

  5. use role=combobox for dropdown with input

    @wxiaoguang
    wxiaoguang committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    2754740 View commit details
    Browse the repository at this point in the history

  6. fix chrome crash

    @wxiaoguang
    wxiaoguang committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    2166ad1 View commit details
    Browse the repository at this point in the history

  7. only change the primary role if there is no role set

    @wxiaoguang
    wxiaoguang committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    5688480 View commit details
    Browse the repository at this point in the history

  8. fix comments

    @wxiaoguang
    wxiaoguang committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    af6d734 View commit details
    Browse the repository at this point in the history

  9. copy dropdown templates to a new object to avoid conflicting

    @wxiaoguang
    wxiaoguang committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    46be3c7 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. fix incorrect language menu behavior

    @wxiaoguang
    wxiaoguang committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    929c3aa View commit details
    Browse the repository at this point in the history

  2. capture blur event

    @wxiaoguang
    wxiaoguang committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    79bc9d8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix-repo-topic-edit

    @wxiaoguang
    wxiaoguang authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    a6baa18 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. fix menu for focus/click on mobile

    @wxiaoguang
    wxiaoguang committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    81c9a99 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. Merge branch 'main' into fix-repo-topic-edit

    @wxiaoguang
    wxiaoguang authored Mar 11, 2023
    Configuration menu
    Copy the full SHA
    41fbd31 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. clarify the combobox/menu by w3.org

    @wxiaoguang
    wxiaoguang committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    da39792 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-repo-topic-edit

    @wxiaoguang
    wxiaoguang committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    47b7811 View commit details
    Browse the repository at this point in the history

  3. fix incorrect dropdown init and fix incorrect visible detection

    @wxiaoguang
    wxiaoguang committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    c208669 View commit details
    Browse the repository at this point in the history

  4. fix tippy bug

    @wxiaoguang
    wxiaoguang committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e912d35 View commit details
    Browse the repository at this point in the history

  5. always use combobox

    @wxiaoguang
    wxiaoguang committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    1fbff84 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into fix-repo-topic-edit

    @wxiaoguang
    wxiaoguang committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    3b8f8bc View commit details
    Browse the repository at this point in the history

  7. fix one more visible check

    @wxiaoguang
    wxiaoguang committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    b17a767 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. revert extracted changes

    @wxiaoguang
    wxiaoguang committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d0ac1f5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-repo-topic-edit 

    # Conflicts:
#	web_src/less/_repository.less
    @wxiaoguang
    wxiaoguang committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    81d6148 View commit details
    Browse the repository at this point in the history

  3. fix merge

    @wxiaoguang
    wxiaoguang committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    e722799 View commit details
    Browse the repository at this point in the history