Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert .Source.SkipVerify to $cfg.SkipVerify #23839

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Convert .Source.SkipVerify to $cfg.SkipVerify #23839

merged 2 commits into from
Apr 3, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Mar 31, 2023

Source doesn't have SkipVerify, it is defined in cfg

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 31, 2023
@lafriks
Copy link
Member

lafriks commented Mar 31, 2023

Imho some sources do have skip verify 🤔

@codecov-commenter
Copy link

Codecov Report

Merging #23839 (9b1de8f) into main (f521e88) will decrease coverage by 0.25%.
The diff coverage is 28.92%.

@@            Coverage Diff             @@
##             main   #23839      +/-   ##
==========================================
- Coverage   47.14%   46.89%   -0.25%     
==========================================
  Files        1149     1158       +9     
  Lines      151446   153179    +1733     
==========================================
+ Hits        71397    71840     +443     
- Misses      71611    72850    +1239     
- Partials     8438     8489      +51
Impacted Files Coverage Δ
cmd/dump.go 0.66% <0.00%> (-0.01%) ⬇️
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/manager_logging.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 5.76% <0.00%> (-0.12%) ⬇️
cmd/restore_repo.go 0.00% <0.00%> (ø)
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.63% <0.00%> (-0.10%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
models/packages/package.go 45.45% <0.00%> (-1.13%) ⬇️
... and 65 more

... and 72 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@techknowlogick techknowlogick added this to the 1.20.0 milestone Mar 31, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 3, 2023
@lunny lunny added outdated/backport/v1.19 This PR should be backported to Gitea 1.19 reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Apr 3, 2023
@jolheiser jolheiser enabled auto-merge (squash) April 3, 2023 15:13
@jolheiser
Copy link
Member

🎺 🤖

@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Apr 3, 2023
@jolheiser jolheiser merged commit 01d9466 into go-gitea:main Apr 3, 2023
@GiteaBot GiteaBot mentioned this pull request Apr 3, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 3, 2023
@yp05327
Convert .Source.SkipVerify to $cfg.SkipVerify (go-gitea#23839)
c12a3d4 
`Source` doesn't have `SkipVerify`, it is defined in `cfg`
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Apr 3, 2023
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 3, 2023
jolheiser pushed a commit that referenced this pull request Apr 3, 2023
@GiteaBot @yp05327
Convert .Source.SkipVerify to $cfg.SkipVerify (#23839) (#23899)
f6dab64 
Backport #23839 by @yp05327

`Source` doesn't have `SkipVerify`, it is defined in `cfg`

Co-authored-by: yp05327 <576951401@qq.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 4, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
bd7f5fc 
* upstream/main:
  Use User.ID instead of User.Name in ActivityPub API for Person IRI (go-gitea#23823)
  Remove fomantic ".link" selector and styles (go-gitea#23888)
  [skip ci] Updated translations via Crowdin
  Fix `cases.Title` crash for concurrency (go-gitea#23885)
  Disable editing tags (go-gitea#23883)
  Fix user profile description rendering (go-gitea#23882)
  Introduce GiteaLocaleNumber custom element to handle number localization on pages. (go-gitea#23861)
  Convert .Source.SkipVerify to $cfg.SkipVerify (go-gitea#23839)
  Fix review box viewport overflow issue (go-gitea#23800)
  Fix owner team access mode value in team_unit table (go-gitea#23675)
  Fix submit button won't refresh in New Repository Fork page (go-gitea#22994)
  Introduce GitHub markdown editor, keep EasyMDE as fallback (go-gitea#23876)
  Improve LoadUnitConfig to handle invalid or duplicate units (go-gitea#23736)
  Append `(comment)` when a link points at a comment rather than the whole issue (go-gitea#23734)
  Rename actions unit to `repo.actions` and add docs for it (go-gitea#23733)
  Try to catch more broken translations (go-gitea#23867)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
8 participants
@yp05327 @lafriks @codecov-commenter @jolheiser @lunny @delvh @techknowlogick @GiteaBot