Remove assertion debug code for show/hide refactoring (#23576) #23868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing the refactoring: * go-gitea#22950 I added some debug mode code (assertShown) to help to catch bugs, it did catch some bugs like: * go-gitea#23074 If it has been proved that there is no more bugs, this assertion could be removed easily and clearly. Feel free to decide when to remove it (feel free to convert it from Draft to Ready for Review). cc: @silverwind
lunny
approved these changes
Apr 2, 2023
GiteaBot
added
the
lgtm/need 1
delvh
approved these changes
Apr 2, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #23576 by @wxiaoguang
When doing the refactoring:
.hideclass, remove inline style=display:none #22950I added some debug mode code (assertShown) to help to catch bugs, it did catch some bugs like:
If it has been proved that there is no more bugs, this assertion could be removed easily and clearly.
Feel free to decide when to remove it (feel free to convert it from Draft to Ready for Review).
cc: @silverwind