Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING following #2329 discussion #2394

Merged
merged 1 commit into from
Aug 28, 2017

Conversation

sapk
Copy link
Member

@sapk sapk commented Aug 25, 2017

Little modification on the creation of release branch before end of release dev and releases candidates.
+fix to follow semver semantic (minor, patch)

Ref : #2329

Creation of release branch before end of release dev and releases candidates + follow semver semantic (minor, patch)
@lunny
Copy link
Member

lunny commented Aug 25, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 25, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 26, 2017
@lunny
Copy link
Member

lunny commented Aug 28, 2017

@tboerger @bkcsoft @appleboy any idea?

@lunny lunny added this to the 1.3.0 milestone Aug 28, 2017
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Aug 28, 2017
@@ -92,7 +92,7 @@ Please use your real name, we really dislike pseudonyms or anonymous contributio

## Release Cycle

We adopted a release schedule to streamline the process of working on, finishing, and issuing releases. The overall goal is to make a major release every two months, which breaks down into one month of general development followed by one month of testing and polishing known as the release freeze. A release is maintained by issuing minor releases to only correct critical problems such as crashes or security issues. All the feature pull requests should be merged in the first month of one release period.
We adopted a release schedule to streamline the process of working on, finishing, and issuing releases. The overall goal is to make a minor release every two months, which breaks down into one month of general development followed by one month of testing and polishing known as the release freeze. All the feature pull requests should be merged in the first month of one release period and during the frozen period a corresponding release branch is open for fix backported from master. Release candidate are made along this period for user testing to obtain a final version that is maintained in this branch. A release is maintained by issuing patch releases to only correct critical problems such as crashes or security issues.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a note on branching release/vX.Y and how -rcX tags work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh nvm, I'm not reading 😂

corresponding release branch is open for fix backported from master. Release candidate are made along this period

@tboerger
Copy link
Member

LGTM

@bkcsoft bkcsoft merged commit 019c90a into go-gitea:master Aug 28, 2017
@sapk sapk deleted the contributing-improvement branch December 9, 2017 21:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants