Enable forbidigo linter

.golangci.yml

@@ -5,6 +5,7 @@ linters:
     - depguard
     - dupl
     - errcheck
+    - forbidigo
     - gocritic
     # - gocyclo # The cyclomatic complexety of a lot of functions is too high, we should refactor those another time.
     - gofmt
@@ -105,6 +106,9 @@ issues:
         - errcheck
         - dupl
         - gosec
+    - path: cmd
+      linters:
+        - forbidigo
     - linters:
         - dupl
       text: "webhook"

contrib/backport/backport.go

@@ -1,6 +1,7 @@
 // Copyright 2023 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
+//nolint:forbidigo
 package main
 
 import (

contrib/fixtures/fixture_generation.go

@@ -1,6 +1,7 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
+//nolint:forbidigo
 package main
 
 import (

models/migrations/base/tests.go

@@ -1,6 +1,7 @@
 // Copyright 2022 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
+//nolint:forbidigo
 package base
 
 import (

models/migrations/v1_11/v112.go

@@ -31,7 +31,7 @@ func RemoveAttachmentMissedRepo(x *xorm.Engine) error {
 		for i := 0; i < len(attachments); i++ {
 			uuid := attachments[i].UUID
 			if err = util.RemoveAll(filepath.Join(setting.Attachment.Path, uuid[0:1], uuid[1:2], uuid)); err != nil {
-				fmt.Printf("Error: %v", err)
+				fmt.Printf("Error: %v", err) //nolint:forbidigo
 			}
 		}
 

models/unittest/fixtures.go

@@ -1,6 +1,7 @@
 // Copyright 2021 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
+//nolint:forbidigo
 package unittest
 
 import (

modules/doctor/paths.go

@@ -106,7 +106,7 @@ func isWritableDir(path string) error {
 		return err
 	}
 	if err := os.Remove(tmpFile.Name()); err != nil {
-		fmt.Printf("Warning: can't remove temporary file: '%s'\n", tmpFile.Name())
+		fmt.Printf("Warning: can't remove temporary file: '%s'\n", tmpFile.Name()) //nolint:forbidigo
 	}
 	tmpFile.Close()
 	return nil

modules/log/event.go

@@ -345,7 +345,7 @@ func (m *MultiChannelledLog) Start() {
 			for _, logger := range m.loggers {
 				err := logger.LogEvent(event)
 				if err != nil {
-					fmt.Println(err)
+					fmt.Println(err) //nolint:forbidigo
 				}
 			}
 			m.rwmutex.RUnlock()
@@ -379,7 +379,7 @@ func (m *MultiChannelledLog) emptyQueue() bool {
 			for _, logger := range m.loggers {
 				err := logger.LogEvent(event)
 				if err != nil {
-					fmt.Println(err)
+					fmt.Println(err) //nolint:forbidigo
 				}
 			}
 			m.rwmutex.RUnlock()

modules/queue/unique_queue_disk_channel_test.go

@@ -4,7 +4,6 @@
 package queue
 
 import (
-	"fmt"
 	"strconv"
 	"sync"
 	"testing"
@@ -17,7 +16,6 @@ import (
 
 func TestPersistableChannelUniqueQueue(t *testing.T) {
 	tmpDir := t.TempDir()
-	fmt.Printf("TempDir %s\n", tmpDir)
 	_ = log.NewLogger(1000, "console", "console", `{"level":"warn","stacktracelevel":"NONE","stderr":true}`)
 
 	// Common function to create the Queue

modules/web/routing/logger_manager.go

@@ -31,7 +31,7 @@ const (
 type Printer func(trigger Event, record *requestRecord)
 
 type requestRecordsManager struct {
-	print Printer
+	print Printer //nolint:forbidigo
 
 	lock sync.Mutex
 

tests/e2e/e2e_test.go

@@ -4,6 +4,7 @@
 // This is primarily coped from /tests/integration/integration_test.go
 //   TODO: Move common functions to shared file
 
+//nolint:forbidigo
 package e2e
 
 import (

tests/integration/integration_test.go

@@ -1,6 +1,7 @@
 // Copyright 2017 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
+//nolint:forbidigo
 package integration
 
 import (

tests/integration/repo_test.go

@@ -354,7 +354,6 @@ func TestViewRepoDirectoryReadme(t *testing.T) {
 
 			htmlDoc := NewHTMLParser(t, resp.Body)
 			_, exists := htmlDoc.doc.Find(".file-view").Attr("class")
-			fmt.Printf("%s", resp.Body)
 
 			assert.False(t, exists, "README should not have rendered")
 		})

tests/test_utils.go

@@ -1,6 +1,7 @@
 // Copyright 2017 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
+//nolint:forbidigo
 package tests
 
 import (