Load reviewer for comments when dismissing a review #24281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfogre
added
type/bug
outdated/backport/v1.19
pull-request-size
bot
added
the
size/S
pull-request-size
bot
added
size/XS
pull-request-size
bot
added
size/S
wolfogre
changed the title
lunny
approved these changes
Apr 23, 2023
GiteaBot
added
the
lgtm/need 1
delvh
approved these changes
Apr 23, 2023
GiteaBot
added
lgtm/done
delvh
added
the
reviewed/wait-merge
|
🤖 🎺 |
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 23, 2023
If a comment dismisses a review, we need to load the reviewer to show whose review has been dismissed. Related to: https://github.com/go-gitea/gitea/blob/20b6ae0e5399cfc22c6a0989d8e520194e920bdd/templates/repo/issue/view_content/comments.tmpl#L765-L770 We don't need `.Review.Reviewer` for all comments, because "dismissing" doesn't happen often, or we would have already received error reports.
techknowlogick
pushed a commit
that referenced
this pull request
Apr 23, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 24, 2023
* giteaofficial/main: (37 commits) [skip ci] Updated translations via Crowdin Add all `no-query` rules to eslint config (go-gitea#24294) Fix bug when deleting wiki with no code write permission (go-gitea#24274) Move code from module to service (go-gitea#24287) Add comments for Manually Merged feature (go-gitea#24291) Allow using localized absolute date times within phrases with place holders and localize issue due date events (go-gitea#24275) Handle canceled workflow as a warning instead of a fail (go-gitea#24282) Tweak pull request branch delete ui (go-gitea#23951) Restore air delay of 1000ms (go-gitea#24290) Load reviewer for comments when dismissing a review (go-gitea#24281) Set type="password" on all auth_token fields (go-gitea#22175) Only delete secrets belonging to its owner (go-gitea#24284) Fix inconsistent wiki path converting. (go-gitea#24277) Change to vertical navbar layout for secondary navbar for repo/user/admin settings (go-gitea#24246) Refactor delete_modal_actions template and use it for project column related actions (go-gitea#24097) update upgrade script to use new CDN (go-gitea#24280) show workflow config error on file view also (go-gitea#24267) Add missing badges in user profile for /projects and /packages (go-gitea#24232) [skip ci] Updated translations via Crowdin Refactor `setting.Other` and remove unused `SHOW_FOOTER_BRANDING` (go-gitea#24270) ... # Conflicts: # templates/base/footer_content.tmpl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a comment dismisses a review, we need to load the reviewer to show whose review has been dismissed.
Related to:
gitea/templates/repo/issue/view_content/comments.tmpl
Lines 765 to 770 in 20b6ae0
Steps to reproduce the bug:
We doesn't need
.Review.Reviewerfor all comments, because "dismissing" doesn't happen often, or we would have already received error reports.