Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace whitespace inside template parens during make fmt #24293

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Replace whitespace inside template parens during make fmt #24293

merged 3 commits into from
Apr 24, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 23, 2023 •
edited
Loading

Remove space/tab after ( and before ) in templates. Only two violations it seems.

@GiteaBot GiteaBot added this to the 1.20.0 milestone Apr 23, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2023
@silverwind silverwind added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 23, 2023
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2023
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 23, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 24, 2023
wxiaoguang
wxiaoguang approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad but I think we should use JS or Go to do such job in the future.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2023
@silverwind
Copy link
Member Author

Yes, if we add more, use a better language. These sed regexes have an ancient syntax.

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 24, 2023
@silverwind silverwind enabled auto-merge (squash) April 24, 2023 06:23
@silverwind silverwind merged commit a319da0 into go-gitea:main Apr 24, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 24, 2023
@silverwind silverwind deleted the parens branch April 24, 2023 07:40
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 24, 2023
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
bc0e314 
* giteaoffical/main:
  Improve some modal action buttons (go-gitea#24289)
  Enable forbidigo linter (go-gitea#24278)
  Fix no edit/close/delete button in org repo project view page  (go-gitea#24301)
  Replace whitespace inside template parens during make fmt (go-gitea#24293)
  Upgrade act  (go-gitea#24298)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @techknowlogick @wxiaoguang @yardenshoham @GiteaBot