Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require repo scope for PATs for private repos and basic authentication (#24362) #24364

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Require repo scope for PATs for private repos and basic authentication (#24362) #24364

merged 1 commit into from
Apr 27, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #24362 by @jolheiser

The scoped token PR just checked all API routes but in fact, some web routes like LFS, git HTTP, container, and attachments supports basic auth. This PR added scoped token check for them.

@jolheiser @lunny @GiteaBot
Require repo scope for PATs for private repos and basic authentication (
9c83bdc 
go-gitea#24362)

> The scoped token PR just checked all API routes but in fact, some web
routes like `LFS`, git `HTTP`, container, and attachments supports basic
auth. This PR added scoped token check for them.

---------

Signed-off-by: jolheiser <john.olheiser@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@GiteaBot GiteaBot added this to the 1.19.2 milestone Apr 27, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 27, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 27, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 27, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) April 27, 2023 00:53
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 27, 2023
@techknowlogick techknowlogick merged commit d2efd2b into go-gitea:release/v1.19 Apr 27, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 27, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
@techknowlogick techknowlogick deleted the backport-24362-v1.19 branch September 9, 2023 05:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees

@jolheiser jolheiser

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.19.2
Development

Successfully merging this pull request may close these issues.
3 participants
@GiteaBot @techknowlogick @jolheiser