Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not select line numbers when selecting text from the action run logs #24594

Merged
merged 1 commit into from
May 8, 2023
Merged

Do not select line numbers when selecting text from the action run logs #24594

merged 1 commit into from
May 8, 2023

Conversation

yardenshoham
Copy link
Member

@yardenshoham
Fix line numbers being selected when selecting a few lines from the a…
42b7bf2 
…ction run logs

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 8, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 8, 2023
@yardenshoham yardenshoham added type/bug topic/gitea-actions related to the actions of Gitea outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels May 8, 2023
@delvh delvh changed the title Fix line numbers being selected when selecting a few lines from the action run logs Do not select line numbers when selecting text from the action run logs May 8, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 8, 2023
@delvh delvh added type/enhancement An improvement of existing functionality and removed type/bug labels May 8, 2023
@delvh delvh added this to the 1.20.0 milestone May 8, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 8, 2023
@jolheiser jolheiser added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 8, 2023
@silverwind silverwind merged commit 9ad5b59 into go-gitea:main May 8, 2023
@GiteaBot GiteaBot mentioned this pull request May 8, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 8, 2023
@yardenshoham @GiteaBot
Do not select line numbers when selecting text from the action run lo…
36a8811 
…gs (go-gitea#24594)

- Fixes go-gitea#24578

# Before

![image](https://user-images.githubusercontent.com/20454870/236873942-26e97f28-6595-4be9-88fa-158870eda253.png)

# After

![image](https://user-images.githubusercontent.com/20454870/236874171-8f0182a5-e953-4740-b875-f3542dee8325.png)

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 8, 2023
@yardenshoham yardenshoham deleted the issues/24578 branch May 8, 2023 18:51
silverwind pushed a commit that referenced this pull request May 8, 2023
@GiteaBot @yardenshoham
Do not select line numbers when selecting text from the action run lo…
7eaf7aa 
…gs (#24594) (#24596)

Backport #24594 by @yardenshoham

- Fixes #24578

# Before

![image](https://user-images.githubusercontent.com/20454870/236873942-26e97f28-6595-4be9-88fa-158870eda253.png)

# After

![image](https://user-images.githubusercontent.com/20454870/236874171-8f0182a5-e953-4740-b875-f3542dee8325.png)

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Yarden Shoham <git@yardenshoham.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 9, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
2090e93 
* upstream/main:
  Add Gitea Profile Readmes (go-gitea#23260)
  Make diff view full width again (go-gitea#24598)
  Add permission check for moving issue action in project view page (go-gitea#24589)
  Update JS dependencies, add new eslint rules (go-gitea#24597)
  Filters for GetAllCommits (go-gitea#24568)
  [skip ci] Updated translations via Crowdin
  Attach a tooltip to the action control button (go-gitea#24595)
  Improve Gitea's web context, decouple "issue template" code into service package (go-gitea#24590)
  Support markdown editor for issue template (go-gitea#24400)
  Do not select line numbers when selecting text from the action run logs (go-gitea#24594)
  In TestViewRepo2, convert computed timezones to local time (go-gitea#24579)
  Fix close org projects (go-gitea#24588)
  Rewrite queue (go-gitea#24505)
  Split "modules/context.go" to separate files (go-gitea#24569)
  Pass 'not' to commit count (go-gitea#24473)
  Refresh the refernce of the closed PR when reopening (go-gitea#24231)
@wolfogre wolfogre mentioned this pull request Jun 19, 2023
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/gitea-actions related to the actions of Gitea type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Gitea Actions Log copies line numbers as well
5 participants
@yardenshoham @jolheiser @delvh @silverwind @GiteaBot