Add eslint-plugin-eslint-comments
#24690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
silverwind
changed the title
eslint-plugin-eslint-comments
yardenshoham
approved these changes
May 12, 2023
GiteaBot
added
lgtm/need 1
silverwind
added
the
reviewed/wait-merge
|
Wonder if this will work, auto merge as soon as next review comes 😆 |
|
Well, that's a first |
delvh
approved these changes
May 12, 2023
| eslint-comments/no-unused-disable: [2] | ||
| eslint-comments/no-unused-enable: [2] | ||
| eslint-comments/no-use: [0] | ||
| eslint-comments/require-description: [0] |
There was a problem hiding this comment.
I'm actually all for enabling this rule.
If PR authors need to disable eslint, they should justify why.
But I understand that it needs quite a bit of work to enable, so can be postponed for now.
There was a problem hiding this comment.
We have this which will require specific rule name to disable, which I think is sufficient.
Comment syntax inside a eslint disable comment is also pretty weird and I didn't know about it until very recently, so it may confuse people on how to even put the requested comment.
/* global $ -- This script using jQuery. */
yardenshoham
added
the
skip-changelog
GiteaBot
removed
the
reviewed/wait-merge
It worked! |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 15, 2023
* upstream/main: (30 commits) Don't filter action runs based on state (go-gitea#24711) Add Go package registry (go-gitea#24687) Fix flash of unstyled content in action view page (go-gitea#24712) Clean up various avatar dimensions (go-gitea#24701) Remove the parallelizing when loading repo for dashboard (go-gitea#24705) Optimize actions list by removing an unnecessary `git` call (go-gitea#24710) Update cron-translations.yml (go-gitea#24708) Fix run list broken when trigger user deleted (go-gitea#24706) Remove Fomantic comment module (go-gitea#24703) Update to Alpine 3.18 (go-gitea#24700) fix minio storage iterator path (go-gitea#24691) Add status indicator on main home screen for each repo (go-gitea#24638) Add test for api team orgnization (go-gitea#24699) Improve button-ghost, remove tertiary button (go-gitea#24692) Add icon support for safari (go-gitea#24697) Improve avatar uploading / resizing / compressing, remove Fomantic card module (go-gitea#24653) Fix docs documenting invalid `@every` for `OLDER_THAN` cron settings (go-gitea#24695) Fix `organization` field being `null` in `GET /api/v1/teams/{id}` (go-gitea#24694) Use standard HTTP library to serve files (go-gitea#24693) Add `eslint-plugin-eslint-comments` (go-gitea#24690) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add eslint-plugin-eslint-comments which prevents some abuse related to eslint comments.