Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add codecov.io service. #2493

Merged
merged 5 commits into from
Sep 13, 2017
Merged

add codecov.io service. #2493

merged 5 commits into from
Sep 13, 2017

Conversation

appleboy
Copy link
Member

Add codecov.io coverage service. See https://codecov.io/gh/go-gitea/gitea

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Sep 12, 2017
@lunny lunny added this to the 1.3.0 milestone Sep 12, 2017
appleboy
appleboy commented Sep 12, 2017
View reviewed changes
Makefile
rm int.coverage.out;\
egrep "$$PKG[^/]*\.go" integration.coverage.out > int.coverage.out;\
gocovmerge $$GOPATH/src/$$PKG/coverage.out int.coverage.out > pkg.coverage.out;\
grep -h -v "^mode:" pkg.coverage.out >> coverage.all;\
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add this line and convert space to tabs.

@tboerger
Copy link
Member

Drone will get integrated coverage with 0.9

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 12, 2017
@lunny
Copy link
Member

lunny commented Sep 12, 2017

@tboerger we can convert back when drone 0.9 is ready.

@ethantkoenig
Copy link
Member

FYI, make coverage is not run in CI as of #2492.

@appleboy
Copy link
Member Author

@ethantkoenig Yes. it will be fixed in this commit: 18ef72f

@lafriks
Copy link
Member

lafriks commented Sep 12, 2017

In generate_coverage there are lot of errors like failed to parse profiles: open /srv/app/src/code.gitea.io/gitea/coverage.out: no such file or directory

@codecov-io
Copy link

codecov-io commented Sep 12, 2017 •
edited
Loading

Codecov Report

Merging #2493 into master will increase coverage by 24.81%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2493       +/-   ##
===========================================
+ Coverage    3.03%   27.85%   +24.81%     
===========================================
  Files          33       83       +50     
  Lines        8108    16825     +8717     
===========================================
+ Hits          246     4686     +4440     
- Misses       7842    11464     +3622     
- Partials       20      675      +655
Impacted Files Coverage Δ
modules/avatar/avatar.go 81.25% <0%> (-4.47%) ⬇️
models/git_diff.go 6.74% <0%> (-1.09%) ⬇️
models/repo_editor.go 0% <0%> (ø) ⬆️
modules/user/user.go 100% <0%> (ø) ⬆️
models/mail.go 0% <0%> (ø) ⬆️
models/login_source.go 0% <0%> (ø) ⬆️
models/release.go 0% <0%> (ø) ⬆️
models/webhook_slack.go 0% <0%> (ø) ⬆️
routers/api/v1/misc/version.go 0% <0%> (ø)
models/issue_milestone.go 60.88% <0%> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef83a9...6959915. Read the comment docs.

@appleboy
Copy link
Member Author

Only two conditions we need to generate the coverage report.

when:
   event: [ push ]
   branch: [ master ]

or

when:
  event: pull_request

tboerger
tboerger suggested changes Sep 12, 2017
View reviewed changes
.drone.yml Outdated
when:
event: [ pull_request ]

test-master:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you separate master and pull requests?

@tboerger
Copy link
Member

You can combine the conditions when event: push, pull_request and branch: master are combined it triggers for pushs on master AND pull requests against master.

@tboerger
Copy link
Member

Ah and beside that I would name the steps the same since anyway only one of them should be executed per build

@appleboy
Copy link
Member Author

@tboerger Done

@bkcsoft
Copy link
Member

bkcsoft commented Sep 12, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 12, 2017
@tboerger
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 13, 2017
@lafriks
Copy link
Member

lafriks commented Sep 13, 2017

@appleboy please rebase

@lafriks
Copy link
Member

lafriks commented Sep 13, 2017

Your makefile needs additional changes after my PR was merged to generate mysql.ini from mysql.ini.tmpl

@appleboy
add codecov.io service.
68cabb9 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
update
e749d8f 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
only PR or master branch (for coverage badge)
8130806 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
update
310a5f7 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
update init
6959915 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy appleboy merged commit 3e89e89 into go-gitea:master Sep 13, 2017
@appleboy appleboy deleted the coverage branch September 13, 2017 12:57
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tboerger tboerger tboerger approved these changes

@lafriks lafriks lafriks approved these changes

@bkcsoft bkcsoft bkcsoft approved these changes

@lunny lunny Awaiting requested review from lunny

@sapk sapk Awaiting requested review from sapk

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
7 participants
@appleboy @tboerger @lunny @ethantkoenig @lafriks @codecov-io @bkcsoft