Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parallelly generating index failure with Mysql (#24567) #25081

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Fix parallelly generating index failure with Mysql (#24567) #25081

merged 2 commits into from
Jun 5, 2023

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Jun 5, 2023

Backport #24567 by @lunny

  • Fix possible parallel creating commit status index problem and creating issues/pull request index problem work with Mysql5/Mysql8
  • Add parallel tests
  • Reenable TestRepoCommitsStatusParallel on CI

Fix #22109

@GiteaBot GiteaBot added this to the 1.19.4 milestone Jun 5, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 5, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 5, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 5, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 5, 2023
@silverwind
Copy link
Member

Lint error, it may need a manual backport:

tests/integration/api_issue_test.go:119:58: AccessTokenScopeWriteIssue not declared by package auth (typecheck)
	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteIssue)
	                                                        ^

@techknowlogick techknowlogick merged commit 3ef9793 into go-gitea:release/v1.19 Jun 5, 2023
@techknowlogick techknowlogick deleted the backport-24567-v1.19 branch June 5, 2023 15:05
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jun 23, 2023
@GiteaBot @earl-warren
Fix parallelly generating index failure with Mysql (go-gitea#24567) (g…
4cd188e 
…o-gitea#25081)

Backport go-gitea#24567 by @lunny

- Fix possible parallel creating commit status index problem and
creating issues/pull request index problem work with Mysql5/Mysql8
- Add parallel tests
- Reenable TestRepoCommitsStatusParallel on CI

Fix go-gitea#22109

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
(cherry picked from commit 3ef9793)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@wolfogre wolfogre wolfogre approved these changes

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees

@lunny lunny

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.19.4
Development

Successfully merging this pull request may close these issues.
5 participants
@GiteaBot @silverwind @lunny @wolfogre @techknowlogick