-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some files under repo/setting #25585
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Jun 29, 2023
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jun 29, 2023
pull-request-size
bot
added
the
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
label
Jun 29, 2023
denyskon
approved these changes
Jul 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be a pretty clean refactor to me 👍
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jul 1, 2023
delvh
approved these changes
Jul 1, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jul 1, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jul 1, 2023
lunny
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jul 1, 2023
Why |
I found one test failed but now restarted it because the error is unrelated. |
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jul 1, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jul 2, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 2, 2023
* giteaoffical/main: (89 commits) Move some files under repo/setting (go-gitea#25585) Following-up improvments for various PRs (go-gitea#25620) Set SSH_AUTHORIZED_KEYS_BACKUP to false (go-gitea#25412) Fix bug of branches API with tests (go-gitea#25578) [skip ci] Updated translations via Crowdin Application as a maintainer (go-gitea#25614) Adding branch-name copy to clipboard branches screen. (go-gitea#25596) Use AfterCommitId to get commit for Viewed functionality (go-gitea#25529) Fix branch commit message too long problem (go-gitea#25588) Restrict `[actions].DEFAULT_ACTIONS_URL` to only `github` or `self` (go-gitea#25581) Add API for changing Avatars (go-gitea#25369) read-only checkboxes don't appear and don't entirely act the way one might expect (go-gitea#25573) Redirect to package after version deletion (go-gitea#25594) Update emoji set to Unicode 15 (go-gitea#25595) Fix `lint-swagger` action (go-gitea#25593) Replace fomantic divider module with our own (go-gitea#25539) Add documentation about supported workflow trigger events (go-gitea#25582) Sync branches into databases (go-gitea#22743) Fix milestones deletion (go-gitea#25583) Reduce table padding globally (go-gitea#25568) ... # Conflicts: # templates/repo/wiki/revision.tmpl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are too many files under
routers/web/repo
and the filerouters/web/repo/setting.go
is too big.This PR move all setting related routers' body functions under
routers/web/repo/setting
and also splitrouters/web/repo/setting.go