Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix branch selector on release page in 1.19 #25706

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Fix branch selector on release page in 1.19 #25706

merged 1 commit into from
Jul 5, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jul 5, 2023 •
edited
Loading

Fix #25705

Regression of #24369

There is no problem in 1.20 because there is #24459

@GiteaBot GiteaBot added this to the 1.19.5 milestone Jul 5, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 5, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2023
@wxiaoguang wxiaoguang mentioned this pull request Jul 5, 2023
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 5, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 5, 2023
@techknowlogick techknowlogick merged commit 67d16c6 into go-gitea:release/v1.19 Jul 5, 2023
@wxiaoguang wxiaoguang deleted the fix-branch-selector branch July 5, 2023 17:14
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jul 12, 2023
@wxiaoguang @earl-warren
Fix branch selector on release page in 1.19 (go-gitea#25706)
b01fb88 
Fix go-gitea#25705

Regression of go-gitea#24369

There is no problem in 1.20 because there is go-gitea#24459

(cherry picked from commit 67d16c6)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.19.5
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @lunny @silverwind @techknowlogick @GiteaBot