Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix margin on the new/edit milestone page #25801

Merged
merged 13 commits into from
Jul 12, 2023
Merged

Fix margin on the new/edit milestone page #25801

merged 13 commits into from
Jul 12, 2023

Conversation

puni9869
Copy link
Member

There is some distortion in desktop and mobile ui for new/edit milestone page.
Fixing the new/edit milestone page for desktop and mobile ui

Design background
https://uxplanet.org/primary-secondary-action-buttons-c16df9b36150
https://balsamiq.com/learn/articles/button-design-best-practices/

Screen shots

Before:
image
image

After
image
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 10, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 10, 2023
@wxiaoguang
Copy link
Contributor

The "column" is for "grid". No grid, no column.

image

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2023
@puni9869 puni9869 force-pushed the punit/Fixing-new-and-edit-milestone-page-ui branch from cb29c31 to 25760b3 Compare July 10, 2023 05:53
@puni9869 puni9869 requested a review from wxiaoguang July 10, 2023 08:29
@puni9869
Copy link
Member Author

@silverwind

@silverwind
Copy link
Member

Don't spam me with mentions please.

denyskon
denyskon approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@denyskon denyskon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the small code style things, but overall a nice fix. I think we'll have to get rid of more of these grid layouts as they impact responsiveness.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 10, 2023
@denyskon denyskon self-requested a review July 10, 2023 18:14
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 10, 2023
@denyskon
Copy link
Member

Is there a reason you switched the button position?

@techknowlogick techknowlogick changed the title Fixing the new/edit milestone page for desktop and mobile ui. Fixing the new/edit milestone page for desktop and mobile ui Jul 10, 2023
@puni9869
Copy link
Member Author

puni9869 commented Jul 10, 2023 •
edited
Loading

Is there a reason you switched the button position?

I found these article.
https://uxplanet.org/primary-secondary-action-buttons-c16df9b36150
https://balsamiq.com/learn/articles/button-design-best-practices/

puni9869 and others added 2 commits July 10, 2023 23:52
@puni9869 @denyskon
Update templates/repo/issue/milestone_new.tmpl
99a8878 
Co-authored-by: Denys Konovalov <privat@denyskon.de>
@puni9869
Removing unused style
558a82e
@denyskon denyskon added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Jul 10, 2023
@denyskon denyskon added this to the 1.21.0 milestone Jul 10, 2023
@denyskon denyskon added the backport/v1.20 This PR should be backported to Gitea 1.20 label Jul 10, 2023
wxiaoguang
wxiaoguang reviewed Jul 11, 2023
View reviewed changes
templates/repo/issue/milestone_new.tmpl Outdated
<div class="divider"></div>
<div class="ui right">
<div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs "gt-text-right", and make the button order as "Cancel" "Submit".

Because, all other Gitea's UI use such layout, it's better to keep consistency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 11, 2023
@puni9869
Copy link
Member Author

puni9869 commented Jul 11, 2023 •
edited
Loading

Same this we can enhance in below page, Ofcourse in the next PR.
image

image

@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 11, 2023
@delvh delvh changed the title Fixing the new/edit milestone page for desktop and mobile ui Fix margin on the new/edit milestone page Jul 11, 2023
@silverwind silverwind enabled auto-merge (squash) July 12, 2023 09:32
@silverwind silverwind merged commit 4744cb3 into go-gitea:main Jul 12, 2023
23 checks passed
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.20. @puni9869, please send one manually. 🍵

go run ./contrib/backport 25801
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jul 12, 2023
@puni9869 puni9869 deleted the punit/Fixing-new-and-edit-milestone-page-ui branch July 12, 2023 11:02
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 14, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
21d25b9 
* giteaofficial/main:
  Fix incorrect release count (go-gitea#25879)
  Add Github related extensions in devcontainer (go-gitea#25800)
  Add error info if no user can fork the repo (go-gitea#25820)
  Fix wrong usage of PathEscapeSegments in branch list page (go-gitea#25864)
  fix incorrect repo url when changed the case of ownername (go-gitea#25733)
  Upgrade go dependencies (go-gitea#25819)
  Don't stack PR tab menu on small screens (go-gitea#25789)
  Link to list of vulnerabilities (go-gitea#25872)
  [skip ci] Updated translations via Crowdin
  move issue filters to shared template (go-gitea#25729)
  [skip ci] Updated translations via Crowdin
  Remove `git.FileBlame` (go-gitea#25841)
  Fix empty project displayed in issue sidebar (go-gitea#25802)
  Update blog links (go-gitea#25843)
  Fix margin on the `new/edit milestone` page (go-gitea#25801)
  Do not "guess" the file encoding/BOM when using API to upload files (go-gitea#25828)
@lunny
Copy link
Member

lunny commented Jul 26, 2023

This needs to be backport

@puni9869
Copy link
Member Author

puni9869 commented Jul 26, 2023 •
edited
Loading

This needs to be backport

Yes. Q. Do I need to send from my side?
I don't have go-gitea/gitea setup in my local. @lunny could you send the backport on my behalf.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@denyskon denyskon denyskon approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/manual No power to the bots! Create your backport yourself! backport/v1.20 This PR should be backported to Gitea 1.20 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
7 participants
@puni9869 @wxiaoguang @silverwind @denyskon @GiteaBot @lunny @delvh