Fix the error message when the token is incorrect (#25701) #25834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we refactored `userIDFromToken` for the token parsing part into a new function `parseToken`. `parseToken` returns the string `token` from request, and a boolean `ok` representing whether the token exists or not. So we can distinguish between token non-existence and token inconsistency in the `verfity` function, thus solving the problem of no proper error message when the token is inconsistent. close go-gitea#24439 related go-gitea#22119 --------- Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: Giteabot <teabot@gitea.io>
GiteaBot
added
type/bug
lgtm/need 2
pull-request-size
bot
added
the
size/M
lunny
approved these changes
Jul 12, 2023
GiteaBot
added
lgtm/need 1
denyskon
approved these changes
Jul 12, 2023
GiteaBot
added
lgtm/done
denyskon
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #25701 by @CaiCandong
we refactored
userIDFromTokenfor the token parsing part into a new functionparseToken.parseTokenreturns the stringtokenfrom request, and a booleanokrepresenting whether the token exists or not. So we can distinguish between token non-existence and token inconsistency in theverfityfunction, thus solving the problem of no proper error message when the token is inconsistent.close #24439
related #22119