Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix margin on the new/edit project page. #25885

Merged

Conversation

puni9869
Copy link
Member

@puni9869 puni9869 commented Jul 14, 2023

New/Edit Project page consistent layout. Fix margin on the new/edit page.

Before:
image
image

After
image
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 14, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 14, 2023
@puni9869 puni9869 changed the title New/Edit Project page consistent layout. Fix margin on the new/edit project page. Jul 14, 2023
@lunny
Copy link
Member

lunny commented Jul 14, 2023

Could you also have a mobile screenshot?

@puni9869
Copy link
Member Author

Could you also have a mobile screenshot?

I forget sorry :)

image image

@silverwind
Copy link
Member

Should do the same on new release page and possibly others to be consistent.

@puni9869
Copy link
Member Author

Yes, I have a curated a list of inconsistent layouts.
This Pr I cooked long before in my local but not raised.
Currently working on release page and other places fixes. Will address those in one PR.

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jul 14, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 14, 2023
@silverwind
Copy link
Member

Yes, I have a curated a list of inconsistent layouts. This Pr I cooked long before in my local but not raised. Currently working on release page and other places fixes. Will address those in one PR.

You mean another PR? I'm ok with that as well.

@puni9869
Copy link
Member Author

Yes, In another Pr I will address those changes.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 14, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 16, 2023
@silverwind silverwind enabled auto-merge (squash) July 16, 2023 14:23
@silverwind silverwind merged commit 8fc4774 into go-gitea:main Jul 16, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jul 16, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 16, 2023
@puni9869 puni9869 deleted the punit/Project-new-edit-pages-layout-fix branch July 16, 2023 18:59
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 18, 2023
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Import `sortablejs` only once (go-gitea#25936)
  Make environment-to-ini work with INSTALL_LOCK=true (go-gitea#25926)
  Ignore `runs-on` with expressions when warning no matched runners (go-gitea#25917)
  Skip unuseful error message in dev mode when watching local filesystem (go-gitea#25919)
  Add shutting down notice (go-gitea#25920)
  Downgrading Snap to build with node/18 instead of node/20
  Fix margin on the new/edit project page. (go-gitea#25885)
  Add 1.20.0 changelog (go-gitea#25901)
  Fix incorrect milestone count when provide a keyword (go-gitea#25880)
  Avoid opening/closing PRs which are already merged (go-gitea#25883)
  Make `add line comment` buttons focusable (go-gitea#25894)
  Fix "Flash" message usage (go-gitea#25895)
  [skip ci] Updated translations via Crowdin
  Add support for different Maven POM encoding (go-gitea#25873)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants