Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor improve NoBetterThan #26126

Merged
merged 15 commits into from
Jul 26, 2023
Merged

refactor improve NoBetterThan #26126

merged 15 commits into from
Jul 26, 2023

Conversation

CaiCandong
Copy link
Member

  • The NoBetterThan function can only handle comparisons between "pending," "success," "error," and "failure." For any other comparison, we directly return false. This prevents logic errors like the one in Fix wrong commit status in web ui #26121.
  • The callers of the NoBetterThan function should also avoid making incomparable calls.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 25, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 25, 2023
@silverwind
Copy link
Member

Please run 'make generate-swagger' and commit the result

@CaiCandong
Copy link
Member Author

Please run 'make generate-swagger' and commit the result

Thanks

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 25, 2023
yp05327
yp05327 reviewed Jul 26, 2023
View reviewed changes
modules/structs/commit_status_test.go Show resolved Hide resolved
modules/structs/commit_status.go Show resolved Hide resolved
modules/structs/commit_status.go Outdated Show resolved Hide resolved
@CaiCandong @yp05327
Update modules/structs/commit_status.go
5adb38f 
Co-authored-by: yp05327 <576951401@qq.com>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 26, 2023
@puni9869
Copy link
Member

puni9869 commented Jul 26, 2023 •
edited
Loading

Thanks @CaiCandong for the unit test cases. Appreciated your efforts. 💯

@CaiCandong @puni9869
Update modules/structs/commit_status.go
578141d 
Co-authored-by: puni9869 <80308335+puni9869@users.noreply.github.com>
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jul 26, 2023
@lunny lunny added this to the 1.21.0 milestone Jul 26, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 26, 2023
@lunny lunny enabled auto-merge (squash) July 26, 2023 05:31
auto-merge was automatically disabled July 26, 2023 05:41

Head branch was pushed to by a user without write access

@lunny lunny enabled auto-merge (squash) July 26, 2023 06:04
@lunny lunny merged commit 1335958 into go-gitea:main Jul 26, 2023
23 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 26, 2023
@CaiCandong CaiCandong deleted the impove-NoBetterThan branch July 26, 2023 10:14
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 28, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
e2d546c 
* giteaofficial/main: (21 commits)
  improve unit test for caching (go-gitea#26185)
  Render plaintext task list items for markdown files (go-gitea#26186)
  Add tooltip to describe LFS table column and color `delete LFS file` button red (go-gitea#26181)
  Show branches and tags that contain a commit (go-gitea#25180)
  Release attachments duplicated check (go-gitea#26176)
  Calculate MAX_WORKERS default value by CPU number (go-gitea#26177)
  Fixing redirection issue for logged-in users (go-gitea#26105)
  Update govulncheck, fix typo (go-gitea#26168)
  Fix handling of plenty Nuget package versions (go-gitea#26075)
  Fix typos in Contributing.md (go-gitea#26170)
  Disable download action logs button when there's no logs (go-gitea#26114)
  Re-add static images to docs (go-gitea#26167)
  Update email-setup.en-us.md (go-gitea#26068)
  Improve display of Labels/Projects/Assignees sort options (go-gitea#25886)
  Fix wrong branch name in rename branch modal (go-gitea#26146)
  Doc update swagger doc for POST /orgs/{org}/teams  (go-gitea#26155)
  Fix UI regression of asciinema player (go-gitea#26159)
  refactor improve NoBetterThan (go-gitea#26126)
  Update Chinese documents (go-gitea#26139)
  Fix bugs in LFS meta garbage collection (go-gitea#26122)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@puni9869 puni9869 puni9869 left review comments

@yp05327 yp05327 yp05327 left review comments

@lunny lunny lunny left review comments

@wolfogre wolfogre wolfogre approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
7 participants
@CaiCandong @silverwind @puni9869 @lunny @wolfogre @yp05327 @GiteaBot