Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editing push mirrors after creation #26151

Merged
merged 30 commits into from
Aug 1, 2023

Conversation

puni9869
Copy link
Member

@puni9869 puni9869 commented Jul 26, 2023

Allow users to edit the sync interval for existing push mirrors.
Currently, there is no way to modify the interval once the mirror is created.

Screenshots

Before

Screenshot 2023-07-26 at 9 31 21 AM

After

Screenshot 2023-07-26 at 9 44 40 AM

On hover

image image image

Edit modal

image

Only valid times are allowed

Screenshot 2023-07-26 at 9 50 01 AM image
Fixes #21295

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 26, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 26, 2023
@lunny lunny added the type/enhancement An improvement of existing functionality label Jul 26, 2023
@lunny lunny added this to the 1.21.0 milestone Jul 26, 2023
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 29, 2023
@puni9869
Copy link
Member Author

Thanks @wxiaoguang for the quick and immediate support.

This pr is ready for review.

@GiteaBot GiteaBot removed the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 29, 2023
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Jul 31, 2023
@puni9869
Copy link
Member Author

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 31, 2023
@silverwind silverwind enabled auto-merge (squash) August 1, 2023 15:42
@puni9869
Copy link
Member Author

puni9869 commented Aug 1, 2023

🚀

@delvh delvh changed the title Introducing Edit Functionality for Mirror Sync Interval in Push Mirrors. Allow editing the Push Mirror Sync Interval Aug 1, 2023
@delvh delvh changed the title Allow editing the Push Mirror Sync Interval Allow editing the push mirror sync interval Aug 1, 2023
@delvh delvh disabled auto-merge August 1, 2023 15:47
@delvh delvh enabled auto-merge (squash) August 1, 2023 15:53
@delvh delvh changed the title Allow editing the push mirror sync interval Allow editing push mirrors after creation Aug 1, 2023
@delvh delvh disabled auto-merge August 1, 2023 15:54
@delvh delvh enabled auto-merge (squash) August 1, 2023 15:54
@delvh delvh merged commit ab388de into go-gitea:main Aug 1, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 1, 2023
@puni9869 puni9869 deleted the punit/add-mirror-repo-update-time branch August 1, 2023 18:46
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 2, 2023
* upstream/main:
  Clarify the logger's MODE config option (go-gitea#26267)
  speed up TestEventSourceManagerRun (go-gitea#26262)
  Merge `templates/projects/list.tmpl` and `templates/repo/projects/list.tmpl` together (go-gitea#26265)
  Allow editing push mirrors after creation (go-gitea#26151)
  Update Arch linux URL from community to extra (go-gitea#26273)
  Fix due date rendering the wrong date in issue (go-gitea#26268)
  Some fixes of the prompt of new branches (go-gitea#26257)
@puni9869 puni9869 mentioned this pull request Aug 26, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to edit mirror interval on repo push mirrors
5 participants