Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more IssueList instead of []*Issue #26369

Merged
merged 4 commits into from
Aug 7, 2023
Merged

Use more IssueList instead of []*Issue #26369

merged 4 commits into from
Aug 7, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 7, 2023

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 7, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 7, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 7, 2023
@puni9869
Copy link
Member

puni9869 commented Aug 7, 2023 •
edited
Loading

_ No description provided. _

Could you add a note what will be the change?

@delvh delvh changed the title Refactor issue list Use more IssueList instead of []*Issue Aug 7, 2023
@delvh
Copy link
Member

delvh commented Aug 7, 2023

Done.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 7, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 7, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 7, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) August 7, 2023 19:05
@techknowlogick techknowlogick merged commit f5dbac9 into go-gitea:main Aug 7, 2023
23 checks passed
@GiteaBot GiteaBot added this to the 1.21.0 milestone Aug 7, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 7, 2023
@lunny lunny deleted the lunny/refactor_issue_list branch August 8, 2023 02:14
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 8, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
5b202b3 
* upstream/main:
  Start using template context function (go-gitea#26254)
  Allow package cleanup from admin page (go-gitea#25307)
  Fix text truncate (go-gitea#26354)
  Fix incorrect sort link with  `.profile`  repository (go-gitea#26374)
  Use more `IssueList` instead of `[]*Issue` (go-gitea#26369)
  Rename code_langauge.go to code_language.go (go-gitea#26377)
  Add changelog for 1.20.3 (go-gitea#26373)
  Do not highlight `#number` in documents (go-gitea#26365)
  Bypass MariaDB performance bug of the "IN" sub-query, fix incorrect IssueIndex (go-gitea#26279)
  Fix nil pointer dereference  error when open link with invalid pull index (go-gitea#26353)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@puni9869 puni9869 puni9869 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @puni9869 @delvh @techknowlogick @GiteaBot